-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update pjs api #906
Conversation
As clarification I used this PR to update the versions again because this didnt go in last week: Updated versions are as follows:
|
I also updated one mock test variable that was actually technically incorrect. But Polkadot-js has added stricter requirements for hash length, so it caught it, and I just made sure it was the correct byte length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@@ -27,4 +27,4 @@ export const MAX_H512 = | |||
'0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
export const MAX_H256 = | |||
'0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
export const MAX_H160 = '0xffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
export const MAX_H160 = '0xffffffffffffffffffffffffffffffffffffffff'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just changes the byte length from 24 -> 20 as that is required for a H160 type and polkadot-js util will no longer shorten the length for you but error with an assert
.
Update the following deps: