fix(dev): updates substrate-js-dev, and fixes latest eslint rules #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
May 18, 2022
niklasad1
approved these changes
May 18, 2022
jsdw
approved these changes
May 18, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
substrate-js-dev@0.6.1.One important change to note:
@typescript-eslint/no-loss-percision: For testing AccountsStakingPayoutsService.spec.ts we were usingBigIntto convert large values. This was inaccurate for the mock data as the actual values returned from p-js areBN. But a result of using theBigIntactually caused us to lose precision. I fixed the tests to accurately communicate the values.console.log(BigInt(33223051661066606)) -> 33223051661066608n