-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add query param to add a tip
, partialFee
, and priority
field to each extrinsic for /node/transaction-pool
#931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good...Just the note about the comment.
/node/transaction-pool
Just to relay @joepetrowski's comment for consideration here: Wouldn't you want to return the total fee including tip? |
@jsdw Yea I am going to rewrite this a bit to include the patialFee, and totalFee. Will request reviews again after. |
/node/transaction-pool
tip
, partialFee
, and priority
field to each extrinsic for /node/transaction-pool
|
||
const maxTxPerBlock = BN.min(maxTxPerBlockWeight, maxTxPerBlockLength); | ||
const saturatedTip = tip.toBn().add(BN_ONE); | ||
const scaledTip = this.maxReward(saturatedTip, maxTxPerBlock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, totally missed that that was a closure in substrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gucci :)
Feature
Summary: Allow
/node/transaction-pool
to accept a query parameter calledincludeFee
. When true it will attach a decodedtip
,partialFee
, andpriority
to each extrinsic.Query Param
includeFee
false
.tip
,partialFee
, andpriority
to each extrinsic within the "pool" array.rel: #925