Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase benchmark threshold #962

Merged
merged 1 commit into from
Jun 16, 2022
Merged

ci: increase benchmark threshold #962

merged 1 commit into from
Jun 16, 2022

Conversation

TarikGul
Copy link
Member

This increases the benchmark threshold to 35000. Some calls may take some time to resolve since the benchmarks focus on stressing the server. This will also stop us from overloading our issues with benchmark regressions. If its over 35000 then I can take the time to investigate the current version.

@TarikGul TarikGul requested a review from a team as a code owner June 15, 2022 11:56
@TarikGul TarikGul requested a review from a team June 15, 2022 12:06
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the benchmark threshold at all?

Fine for me, I assume this is tightly coupled to the RPC node.
IIRC, the sidecar RPC node was switched out to a shared one which may decrease the throughput...

@TarikGul
Copy link
Member Author

Do we really need the benchmark threshold at all?

Fine for me, I assume this is tightly coupled to the RPC node. IIRC, the sidecar RPC node was switched out to a shared one which may decrease the throughput...

Yea I see where you are coming from. I think the threshold holds one merit where if there is an egregious request that takes too much time, it might be worth investigating. Hence the large increase. I think everything we have seen so far is kinda normal behavior, but there was times in the past where requests would take 40000ms and we were able to find regressions. (This had to do with the metadatav14 transition). So all in all I think it might be nice to have this be a last barrier of sanity.

@TarikGul TarikGul merged commit bb5dea9 into master Jun 16, 2022
@TarikGul TarikGul deleted the tarik-benchmark-const branch June 16, 2022 14:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants