Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set minCalcFee runtime to 1058 for kusama #966

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

TarikGul
Copy link
Member

closes: #429

The lowest runtime which supports fee calculation given payment::queryInfo is 1058 for kusama.
This updates that, and adds an e2e test for it.

@TarikGul TarikGul requested a review from a team as a code owner June 17, 2022 17:55
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you work out what the lowest runtime version was to support it out of interest?

@TarikGul
Copy link
Member Author

@jsdw Manually :), So I used subscan as a way to go back to the earliest blocks. Then went through each runtime, and found blocks with balance transfer extrinsics and would test against those.

@TarikGul TarikGul self-assigned this Jun 21, 2022
@TarikGul TarikGul merged commit e3adacc into master Jun 21, 2022
@TarikGul TarikGul deleted the tarik-kusama-fees branch June 21, 2022 13:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate supporting fee calculations in all Kusama runtimes
3 participants