Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all non polkadot-js deps #988

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Conversation

TarikGul
Copy link
Member

There are two changes to the code base here:

  1. With the LRU-cache update we need to explicitly instantiate the LRU class with a min or max length. So we fixed that in the tests for BlocksService.spec.ts.

  2. For our logging we use TransformableInfo as our type for our info. In logform this has been updated to have any types. I fixed that by making our own ITransformableInfo type that has explicit type assignment.

@TarikGul TarikGul requested a review from a team as a code owner July 19, 2022 14:33
@TarikGul TarikGul self-assigned this Jul 19, 2022
Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransformableInfo is also found in the following files :

Shouldn't we also replace it with ITransformableInfo in these files too ?

src/types/logging/index.ts Show resolved Hide resolved
src/types/logging/Transformers.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/logging/transports/consoleTransport.ts Outdated Show resolved Hide resolved
TarikGul and others added 5 commits July 27, 2022 08:40
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants