-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update all non polkadot-js deps #988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Jul 20, 2022
Imod7
reviewed
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TransformableInfo
is also found in the following files :
- nodeUtilFormat in L27
- stripAnsi in L51
Shouldn't we also replace it with ITransformableInfo
in these files too ?
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
Co-authored-by: Dominique <dsaripapazoglou@gmail.com>
lexnv
approved these changes
Jul 27, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes to the code base here:
With the LRU-cache update we need to explicitly instantiate the
LRU
class with a min or max length. So we fixed that in the tests forBlocksService.spec.ts
.For our logging we use
TransformableInfo
as our type for ourinfo
. Inlogform
this has been updated to haveany
types. I fixed that by making our ownITransformableInfo
type that has explicit type assignment.