Migrate substrate pallets to use `pallet!` #7882

gui1117 · 2021-01-12T13:09:15Z

kianenigma · 2021-01-13T11:40:21Z

pallet-executive

Is this a mistake?

pallet-elections

I wouldn't migrate this one until an external team or someone asks for it tbh. It is not really maintained.

Part of #7882. Converts the `Proxy` pallet to the new pallet attribute macro introduced in #6877. [Upgrade guidelines used](https://substrate.dev/rustdocs/v3.0.0/frame_support/attr.pallet.html#upgrade-guidelines). ## ⚠️ Breaking Change ⚠️ From [checking upgrade guidelines](https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines) > storages now use PalletInfo for module_prefix instead of the one given to `decl_storage`: use of this pallet in `construct_runtime!` needs careful updating of the name in order to not break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change. So users of the `Assets` pallet must be careful about the name they used in `construct_runtime!`. Hence the `runtime-migration` label, which might not be needed depending on the configuration of the `Assets` pallet. ### Notes There are some changes to the docs in metadata for the constants. The docs in the metadata for constants are now more complete.

* Migrate pallet-proxy to pallet attribute macro Part of #7882. Converts the `Proxy` pallet to the new pallet attribute macro introduced in #6877. [Upgrade guidelines used](https://substrate.dev/rustdocs/v3.0.0/frame_support/attr.pallet.html#upgrade-guidelines). ## ⚠️ Breaking Change ⚠️ From [checking upgrade guidelines](https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines) > storages now use PalletInfo for module_prefix instead of the one given to `decl_storage`: use of this pallet in `construct_runtime!` needs careful updating of the name in order to not break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change. So users of the `Assets` pallet must be careful about the name they used in `construct_runtime!`. Hence the `runtime-migration` label, which might not be needed depending on the configuration of the `Assets` pallet. ### Notes There are some changes to the docs in metadata for the constants. The docs in the metadata for constants are now more complete.

shaunxw · 2021-03-17T22:59:09Z

* [ ]  pallet-babe @shamb0

* [ ]  pallet-utility @shamb0

@thiolliere Some mistakes here, it should be:

pallet-babe @shaunxw Migrate pallet-babe to pallet attribute macro. #8310
pallet-utility @shaunxw Migrate pallet-utility to pallet attribute macro. #8326

shawntabrizi · 2021-04-14T07:29:53Z

Here is an issue for migrating the Polkadot pallets: paritytech/polkadot#2882

* Migrate pallet-proxy to pallet attribute macro Part of paritytech#7882. Converts the `Proxy` pallet to the new pallet attribute macro introduced in paritytech#6877. [Upgrade guidelines used](https://substrate.dev/rustdocs/v3.0.0/frame_support/attr.pallet.html#upgrade-guidelines). ## ⚠️ Breaking Change ⚠️ From [checking upgrade guidelines](https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines) > storages now use PalletInfo for module_prefix instead of the one given to `decl_storage`: use of this pallet in `construct_runtime!` needs careful updating of the name in order to not break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change. So users of the `Assets` pallet must be careful about the name they used in `construct_runtime!`. Hence the `runtime-migration` label, which might not be needed depending on the configuration of the `Assets` pallet. ### Notes There are some changes to the docs in metadata for the constants. The docs in the metadata for constants are now more complete.

shaunxw · 2021-06-10T04:09:22Z

These pallets migration are merged and can be ticked now:

pallet-democracy
pallet-multisig
pallet-scheduler

koushiro · 2021-06-10T08:30:34Z

I plan to continue migrating pallet-collective and pallet-membership to pallet attribute macro, is anyone working on it?

BTW, it seems that pallet-transaction-payment has not yet migrated to the new pallet attribute macro.

[x] pallet-transaction-payment @kianenigma #8044

gui1117 · 2021-06-10T08:46:20Z

I put your name, nobody is working on it AFAIK

apopiak · 2021-06-11T09:38:04Z

Just a note that we want to mark the extrinsics as pub (instead of pub(crate) from now on (see this PR: #9078).

koushiro · 2021-06-11T10:44:44Z

@shawntabrizi I found a issue in the process of migrating pallet-membership to new pallet attribute macro (#9080). The storage prefix and pallet name in the metadata, generated by the new pallet macro, are consistent, but for the pallets that use the instance and the old macro, Instance+PalletName will be used as the storage prefix.
I saw issue #8391, but I want to know if there is a specific macro syntax to solve this problem.

metadata generated by old macro

{
  "name": "TechnicalMembership",
  "storage": {
    "prefix": "Instance1Membership",
    "entries": [
      {
        "name": "Members",
        "modifier": "Default",
        "ty": {
          "Plain": "Vec<T::AccountId>"
        },
        "default": [
          0
        ],
        "documentation": [
          " The current membership, stored as an ordered Vec."
        ]
      },
      {
        "name": "Prime",
        "modifier": "Optional",
        "ty": {
          "Plain": "T::AccountId"
        },
        "default": [
          0
        ],
        "documentation": [
          " The current prime member, if one exists."
        ]
      }
    ]
  },
  "calls": [
    {
      "name": "add_member",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Add a member `who` to the set.",
        "",
        " May only be called from `T::AddOrigin`."
      ]
    },
    {
      "name": "remove_member",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Remove a member `who` from the set.",
        "",
        " May only be called from `T::RemoveOrigin`."
      ]
    },
    {
      "name": "swap_member",
      "arguments": [
        {
          "name": "remove",
          "ty": "T::AccountId"
        },
        {
          "name": "add",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Swap out one member `remove` for another `add`.",
        "",
        " May only be called from `T::SwapOrigin`.",
        "",
        " Prime membership is *not* passed from `remove` to `add`, if extant."
      ]
    },
    {
      "name": "reset_members",
      "arguments": [
        {
          "name": "members",
          "ty": "Vec<T::AccountId>"
        }
      ],
      "documentation": [
        " Change the membership to a new set, disregarding the existing membership. Be nice and",
        " pass `members` pre-sorted.",
        "",
        " May only be called from `T::ResetOrigin`."
      ]
    },
    {
      "name": "change_key",
      "arguments": [
        {
          "name": "new",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Swap out the sending member for some other key `new`.",
        "",
        " May only be called from `Signed` origin of a current member.",
        "",
        " Prime membership is passed from the origin account to `new`, if extant."
      ]
    },
    {
      "name": "set_prime",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Set the prime member. Must be a current member.",
        "",
        " May only be called from `T::PrimeOrigin`."
      ]
    },
    {
      "name": "clear_prime",
      "arguments": [],
      "documentation": [
        " Remove the prime member if it exists.",
        "",
        " May only be called from `T::PrimeOrigin`."
      ]
    }
  ],
  "event": [
    {
      "name": "MemberAdded",
      "arguments": [],
      "documentation": [
        " The given member was added; see the transaction for who."
      ]
    },
    {
      "name": "MemberRemoved",
      "arguments": [],
      "documentation": [
        " The given member was removed; see the transaction for who."
      ]
    },
    {
      "name": "MembersSwapped",
      "arguments": [],
      "documentation": [
        " Two members were swapped; see the transaction for who."
      ]
    },
    {
      "name": "MembersReset",
      "arguments": [],
      "documentation": [
        " The membership was reset; see the transaction for who the new set is."
      ]
    },
    {
      "name": "KeyChanged",
      "arguments": [],
      "documentation": [
        " One of the members' keys changed."
      ]
    },
    {
      "name": "Dummy",
      "arguments": [
        "sp_std::marker::PhantomData<(AccountId, Event)>"
      ],
      "documentation": [
        " Phantom member, never used."
      ]
    }
  ],
  "constants": [],
  "errors": [
    {
      "name": "AlreadyMember",
      "documentation": [
        " Already a member."
      ]
    },
    {
      "name": "NotMember",
      "documentation": [
        " Not a member."
      ]
    }
  ],
  "index": 15
}

metadata generated by new macro

{
  "name": "TechnicalMembership",
  "storage": {
    "prefix": "TechnicalMembership",
    "entries": [
      {
        "name": "Members",
        "modifier": "Default",
        "ty": {
          "Plain": "Vec<T::AccountId>"
        },
        "default": [
          0
        ],
        "documentation": [
          " The current membership, stored as an ordered Vec."
        ]
      },
      {
        "name": "Prime",
        "modifier": "Optional",
        "ty": {
          "Plain": "T::AccountId"
        },
        "default": [
          0
        ],
        "documentation": [
          " The current prime member, if one exists."
        ]
      }
    ]
  },
  "calls": [
    {
      "name": "add_member",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Add a member `who` to the set.",
        "",
        " May only be called from `T::AddOrigin`."
      ]
    },
    {
      "name": "remove_member",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Remove a member `who` from the set.",
        "",
        " May only be called from `T::RemoveOrigin`."
      ]
    },
    {
      "name": "swap_member",
      "arguments": [
        {
          "name": "remove",
          "ty": "T::AccountId"
        },
        {
          "name": "add",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Swap out one member `remove` for another `add`.",
        "",
        " May only be called from `T::SwapOrigin`.",
        "",
        " Prime membership is *not* passed from `remove` to `add`, if extant."
      ]
    },
    {
      "name": "reset_members",
      "arguments": [
        {
          "name": "members",
          "ty": "Vec<T::AccountId>"
        }
      ],
      "documentation": [
        " Change the membership to a new set, disregarding the existing membership. Be nice and",
        " pass `members` pre-sorted.",
        "",
        " May only be called from `T::ResetOrigin`."
      ]
    },
    {
      "name": "change_key",
      "arguments": [
        {
          "name": "new",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Swap out the sending member for some other key `new`.",
        "",
        " May only be called from `Signed` origin of a current member.",
        "",
        " Prime membership is passed from the origin account to `new`, if extant."
      ]
    },
    {
      "name": "set_prime",
      "arguments": [
        {
          "name": "who",
          "ty": "T::AccountId"
        }
      ],
      "documentation": [
        " Set the prime member. Must be a current member.",
        "",
        " May only be called from `T::PrimeOrigin`."
      ]
    },
    {
      "name": "clear_prime",
      "arguments": [],
      "documentation": [
        " Remove the prime member if it exists.",
        "",
        " May only be called from `T::PrimeOrigin`."
      ]
    }
  ],
  "event": [
    {
      "name": "MemberAdded",
      "arguments": [],
      "documentation": [
        " The given member was added; see the transaction for who."
      ]
    },
    {
      "name": "MemberRemoved",
      "arguments": [],
      "documentation": [
        " The given member was removed; see the transaction for who."
      ]
    },
    {
      "name": "MembersSwapped",
      "arguments": [],
      "documentation": [
        " Two members were swapped; see the transaction for who."
      ]
    },
    {
      "name": "MembersReset",
      "arguments": [],
      "documentation": [
        " The membership was reset; see the transaction for who the new set is."
      ]
    },
    {
      "name": "KeyChanged",
      "arguments": [],
      "documentation": [
        " One of the members' keys changed."
      ]
    },
    {
      "name": "Dummy",
      "arguments": [
        "PhantomData<(T::AccountId,<T as Config<I>>::Event)>"
      ],
      "documentation": [
        " Phantom member, never used."
      ]
    }
  ],
  "constants": [],
  "errors": [
    {
      "name": "AlreadyMember",
      "documentation": [
        " Already a member."
      ]
    },
    {
      "name": "NotMember",
      "documentation": [
        " Not a member."
      ]
    }
  ],
  "index": 15
}

diff:

4c4
<     "prefix": "Instance1Membership",
---
>     "prefix": "TechnicalMembership",
177c177
<         "sp_std::marker::PhantomData<(AccountId, Event)>"
---
>         "PhantomData<(T::AccountId,<T as Config<I>>::Event)>"

gui1117 · 2021-06-11T11:04:38Z

@shawntabrizi I found a issue in the process of migrating pallet-membership to new pallet attribute macro (#9080). The storage prefix and pallet name in the metadata, generated by the new pallet macro, are consistent, but for the pallets that use the instance and the old macro, Instance+PalletName will be used as the storage prefix.
I saw issue #8391, but I want to know if there is a specific macro syntax to solve this problem.

the solution is to migrate the storages, in order to use their new pallet prefix.
The issue #8391 could help, but I don't think it is the correct way to solve it. Using the pallet name for pallet prefix is more future proof I think.

koushiro · 2021-06-11T11:13:36Z

@thiolliere ~~Is it possible to cause storage conflicts? e.g. Council and TechnicalCommitte use the same pallet(pallet-collective), but different instances.~~
Oops, I was wrong, this should not cause storage conflicts

OLUWAMUYIWA · 2021-06-25T15:31:36Z

What more is there to contribute to here, people?

OLUWAMUYIWA · 2021-06-25T15:33:03Z

I plan to migrate pallet-society. Is anyone else working on it?

gui1117 · 2021-06-28T07:51:19Z

I plan to migrate pallet-society. Is anyone else working on it?

good, I'm not aware of anybody working on it yet

OLUWAMUYIWA · 2021-06-28T09:40:58Z

Okay then. I have picked it

gui1117 · 2021-11-17T07:19:47Z

finally finished for substrate pallets, thanks for all contributions

shawntabrizi · 2021-11-18T14:27:18Z

Big thank you to everyone for this!

This was referenced Jan 14, 2021

Migrate frame-system to pallet attribute macro #7898

Merged

Migrate pallet-balances to pallet attribute macro #7936

Merged

ascjones mentioned this issue Jan 25, 2021

Make all type information available via the metadata endpoint #7971

Closed

g2udevelopment mentioned this issue Jan 25, 2021

Migrate pallet-template to pallet attribute macro #7981

Merged

dvdplm mentioned this issue Jan 26, 2021

Migrate assets pallet to new macros #7984

Merged

kianenigma mentioned this issue Feb 4, 2021

migrate pallet-elections-phragmen to attribute macros #8044

Merged

shaunxw mentioned this issue Feb 9, 2021

Migrate pallet-timestamp to pallet attribute macro. #8078

Merged

gui1117 mentioned this issue Feb 16, 2021

Migrate examples to use pallet macro #8138

Merged

ascjones mentioned this issue Feb 22, 2021

Import runtime Call / Storage metadata without import the whole runtime #8158

Open

gui1117 mentioned this issue Feb 22, 2021

pallet-collective | port to frame v2 #8151

Closed

This was referenced Feb 23, 2021

pallet-treasury | port to frame v2 #8179

Closed

pallet-collective | port to frame v2 #8193

Closed

pallet-treasury | port to frame v2 #8196

Closed

# pallet-tips | port to frame v2 #8204

Closed

pallet-tips | port to frame v2 #8205

Closed

This was referenced Mar 10, 2021

Migrate pallet-babe to pallet attribute macro. #8310

Merged

Migrate pallet-utility to pallet attribute macro. #8326

Merged

kaichaosun mentioned this issue Mar 12, 2021

Migrate node authorization pallet to FRAME v2 #8337

Merged

emostov mentioned this issue Mar 16, 2021

Migrate pallet-proxy to pallet attribute macro #8365

Merged

shaunxw mentioned this issue Mar 24, 2021

Migrate pallet-vesting to pallet attribute macro. #8440

Merged

ascjones mentioned this issue Mar 24, 2021

Migrate pallet-sudo to pallet! #8448

Merged

gui1117 mentioned this issue Mar 25, 2021

Upgrade pallet atomic swap to FRAME v2 #8452

Merged

shamb0 mentioned this issue Mar 26, 2021

pallet-tips | port to frame v2 shamb0/substrate#6

Closed

ascjones mentioned this issue Mar 26, 2021

Migrate pallet-indices to pallet! #8465

Merged

koushiro mentioned this issue Jun 10, 2021

Migrate pallet-randomness-collective-flip to pallet attribute macro #9061

Merged

koushiro mentioned this issue Jun 11, 2021

Migrate pallet-membership to the new pallet attribute macro #9080

Merged

shaunxw mentioned this issue Jun 11, 2021

Migrate pallet-staking to pallet attribute macro #9083

Merged

koushiro mentioned this issue Jun 11, 2021

Migrate pallet-transaction-payment to new pallet attribute macro #9087

Merged

shaunxw mentioned this issue Jun 12, 2021

Migrate pallet-elections to pallet attribute macro #9088

Merged

koushiro mentioned this issue Jun 15, 2021

Migrate pallet-collective to the new pallet attribute macro #9115

Merged

0xrjman mentioned this issue Jun 15, 2021

Migrate xpallets-assets to attribute macro chainx-org/ChainX#560

Merged

This was referenced Jun 23, 2021

Migrate pallet-mmr to the new pallet attribute macro #9181

Merged

Migrate pallet-treasury to the new pallet attribute macro #9197

Merged

ferrell-code mentioned this issue Aug 2, 2021

Society Pallet to FrameV2 #9472

Merged

ferrell-code mentioned this issue Aug 14, 2021

Bounties Pallet to FrameV2 #9566

Merged

koushiro mentioned this issue Sep 7, 2021

Migrate pallet-tips to the new pallet attribute macro #9711

Merged

koushiro mentioned this issue Sep 16, 2021

Migrate pallet-session to the new pallet macro #9796

Merged

koushiro mentioned this issue Sep 28, 2021

pallet-session: Migrate the historical part to the new pallet macro #9878

Merged

gui1117 closed this as completed Nov 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate substrate pallets to use `pallet!` #7882

Migrate substrate pallets to use `pallet!` #7882

gui1117 commented Jan 12, 2021 •

edited

Loading

kianenigma commented Jan 13, 2021

shaunxw commented Mar 17, 2021 •

edited by gui1117

Loading

shawntabrizi commented Apr 14, 2021

shaunxw commented Jun 10, 2021

koushiro commented Jun 10, 2021 •

edited

Loading

gui1117 commented Jun 10, 2021

apopiak commented Jun 11, 2021

koushiro commented Jun 11, 2021 •

edited

Loading

gui1117 commented Jun 11, 2021

koushiro commented Jun 11, 2021 •

edited

Loading

OLUWAMUYIWA commented Jun 25, 2021

OLUWAMUYIWA commented Jun 25, 2021

gui1117 commented Jun 28, 2021 •

edited

Loading

OLUWAMUYIWA commented Jun 28, 2021

gui1117 commented Nov 17, 2021

shawntabrizi commented Nov 18, 2021

Migrate substrate pallets to use pallet! #7882

Migrate substrate pallets to use pallet! #7882

Comments

gui1117 commented Jan 12, 2021 • edited Loading

kianenigma commented Jan 13, 2021

shaunxw commented Mar 17, 2021 • edited by gui1117 Loading

shawntabrizi commented Apr 14, 2021

shaunxw commented Jun 10, 2021

koushiro commented Jun 10, 2021 • edited Loading

gui1117 commented Jun 10, 2021

apopiak commented Jun 11, 2021

koushiro commented Jun 11, 2021 • edited Loading

gui1117 commented Jun 11, 2021

koushiro commented Jun 11, 2021 • edited Loading

OLUWAMUYIWA commented Jun 25, 2021

OLUWAMUYIWA commented Jun 25, 2021

gui1117 commented Jun 28, 2021 • edited Loading

OLUWAMUYIWA commented Jun 28, 2021

gui1117 commented Nov 17, 2021

shawntabrizi commented Nov 18, 2021

Migrate substrate pallets to use `pallet!` #7882

Migrate substrate pallets to use `pallet!` #7882

gui1117 commented Jan 12, 2021 •

edited

Loading

shaunxw commented Mar 17, 2021 •

edited by gui1117

Loading

koushiro commented Jun 10, 2021 •

edited

Loading

koushiro commented Jun 11, 2021 •

edited

Loading

koushiro commented Jun 11, 2021 •

edited

Loading

gui1117 commented Jun 28, 2021 •

edited

Loading