Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change intial best beefy block #10669

Closed
wants to merge 15 commits into from
Closed

Change intial best beefy block #10669

wants to merge 15 commits into from

Conversation

Wizdave97
Copy link
Contributor

@Wizdave97 Wizdave97 commented Jan 14, 2022 •
edited
Loading

This PR provides a runtime storage value in the session pallet that holds the block number of when session changes occur.

Fixes paritytech/grandpa-bridge-gadget#256 when done

polkadot companion: paritytech/polkadot#4729

@Wizdave97 Wizdave97 marked this pull request as draft January 14, 2022 21:30
@Wizdave97 Wizdave97 marked this pull request as ready for review January 17, 2022 08:18
@Wizdave97 Wizdave97 changed the title Create session boundary runtime API Change intial best beefy block Jan 17, 2022
@Wizdave97 Wizdave97 mentioned this pull request Jan 17, 2022
Open
bkchr
bkchr suggested changes Jan 17, 2022
View reviewed changes
primitives/session/src/lib.rs Outdated Show resolved Hide resolved
frame/session/src/lib.rs Outdated Show resolved Hide resolved
client/beefy/src/worker.rs Outdated Show resolved Hide resolved
@Wizdave97 Wizdave97 requested a review from bkchr January 17, 2022 19:44
@Wizdave97
Copy link
Contributor Author

The polkadot companion has been fixed, the CI checks need to be restarted

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jan 24, 2022
acatangiu
acatangiu approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Wizdave97 Wizdave97 mentioned this pull request Jan 24, 2022
Closed
@acatangiu
Copy link
Contributor

@bkchr please take a look at this PR and its companion, thanks!

@acatangiu acatangiu mentioned this pull request Jan 28, 2022
Merged
@stale
Copy link

stale bot commented Feb 25, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 25, 2022
@seunlanlege
Copy link
Contributor

Bump

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Feb 25, 2022
@stale
Copy link

stale bot commented Mar 27, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 27, 2022
@acatangiu
Copy link
Contributor

Alternative PR #10882 merged

@acatangiu acatangiu closed this Mar 28, 2022
@louismerlin louismerlin removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the initial best_beefy_block
5 participants
@Wizdave97 @acatangiu @seunlanlege @bkchr @louismerlin