rpc: Implement archive RPC API

[lexnv]

This PR implements the archive methods.

The archive methods include:

• archive_unstable_body - Get the extrinsics of a block
• archive_unstable_genesisHash - Get the genesis hash of the chain
• archive_unstable_hashByHeight - Get the block hashes from a certain height of the block
• archive_unstable_header - Get the header of a block hash
• archive_unstable_storage - Query storage of a block

This PR also includes the unsubscribe methods.

Part of: #12071.

Testing Done

Manual Testing

archive_unstable_genesisHash: String("0x38c857c72005bf68bb1af4ac83405d94a9e2914850e33a4a3dfe8a5e5e2af8cd")
archive_unstable_hashByHeight on height=0 result: Ok(Object({"event": String("done"), "result": Array([String("0x38c857c72005bf68bb1af4ac83405d94a9e2914850e33a4a3dfe8a5e5e2af8cd")])}))
  archive_unstable_body hash="0x38c857c72005bf68bb1af4ac83405d94a9e2914850e33a4a3dfe8a5e5e2af8cd" result: Ok(Object({"event": String("done"), "result": String("0x00")}))
  archive_unstable_header hash="0x38c857c72005bf68bb1af4ac83405d94a9e2914850e33a4a3dfe8a5e5e2af8cd" result: Ok(Object({"event": String("done"), "result": String("0x000000000000000000000000000000000000000000000000000000000000000000483ec7c7e75d37442d10423ccef114efe2a4775125698d2d892113f85ee684c703170a2e7597b7b7e3d84c05391d139a62b157e78786d8c082f29dcf4c11131400")}))
archive_unstable_hashByHeight on height=1 result: Ok(Object({"event": String("done"), "result": Array([String("0xebcb7707bad09570beac92ca85abb47935574fe28515c9164e9a38df01ce2944")])}))
  archive_unstable_body hash="0xebcb7707bad09570beac92ca85abb47935574fe28515c9164e9a38df01ce2944" result: Ok(Object({"event": String("done"), "result": String("0x04280403000b98c6259b8401")}))
  archive_unstable_header hash="0xebcb7707bad09570beac92ca85abb47935574fe28515c9164e9a38df01ce2944" result: Ok(Object({"event": String("done"), "result": String("0x38c857c72005bf68bb1af4ac83405d94a9e2914850e33a4a3dfe8a5e5e2af8cd0418295f07a92d920bc1c281a5fee7531e9d0a71178e97a4747bc49be61677c528f7e7482f598e7e47123eda84423b8ee84328e023b6dd0209bc377c21f88d54e50c0642414245340200000000853a292100000000044241424529010104d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d01000000000000000000000000000000000000000000000000000000000000000000000000000000054241424501014c890f007ffa8c3f0ecae68d41ec23a19ac9ede57c02e38c7266dbb4ec1e2d6e617dcb9ab96a80399b33939f7c4229308806c39eb6b34046c17731a90e7dae8a")}))
archive_unstable_hashByHeight on height=2 result: Ok(Object({"event": String("done"), "result": Array([String("0x106c5d1e1049f01e0036dd40c0c50599e55df4c552ea87c5d93b637c46ad71ba")])}))
  archive_unstable_body hash="0x106c5d1e1049f01e0036dd40c0c50599e55df4c552ea87c5d93b637c46ad71ba" result: Ok(Object({"event": String("done"), "result": String("0x04280403000b51d2259b8401")}))
  archive_unstable_header hash="0x106c5d1e1049f01e0036dd40c0c50599e55df4c552ea87c5d93b637c46ad71ba" result: Ok(Object({"event": String("done"), "result": String("0xebcb7707bad09570beac92ca85abb47935574fe28515c9164e9a38df01ce294408cd89427a3c56994eedaf1fc721339cd1bb8b363fa3ee937f1304a2c29c417119e99e9e8aee3b0effeb81f7fbd2fa3f5aa5d42ab953dc45fbe0fabeb04b60d077080642414245b5010100000000863a2921000000001ca2bd43a3b0d6a88b5a83f91ce93aa8f341650a87c262b524daf268a55b4738f9effe0bff6f33df69d679d9da706a820cb5adaa9c74ddd261d2d3b660db1d0ccf6f92023f3504ee99ceb3b3494235c242f90ea794535745de4313ae7e707304054241424501011a17a5890c212be368aeb28502ff9088c06896e5eac47953bcc7e1d016cc162bb375b169f924ecfe77db82816fe5ca0961da3346e9d080bbee4dceb44c038e8c")}))
archive_unstable_hashByHeight on height=3 result: Ok(Object({"event": String("done"), "result": Array([String("0x0b674621222e81a8db5b67386dffd6c24504c93d9080e6186149370226f7184a")])}))
  archive_unstable_body hash="0x0b674621222e81a8db5b67386dffd6c24504c93d9080e6186149370226f7184a" result: Ok(Object({"event": String("done"), "result": String("0x04280403000b08de259b8401")}))
  archive_unstable_header hash="0x0b674621222e81a8db5b67386dffd6c24504c93d9080e6186149370226f7184a" result: Ok(Object({"event": String("done"), "result": String("0x106c5d1e1049f01e0036dd40c0c50599e55df4c552ea87c5d93b637c46ad71ba0ca77e4418b7a1455bf8093fa79c6def40c595de82702d260b6a3507b0e45451d82e9e88b179af804e16c274917c4621e3deceea3e347a34fd5725df3407c03585080642414245b5010100000000873a2921000000002e99d1d4296672f4333e220c190666a08907925de0d10ed9c27a54789e20e76d896fb97d45a9c83d5b8bf760a3b93d3278b801f673663ffbd9fbb5782655990b8464470519e7d2ef9f7415ce75c67e12bc13c701e94981cb45d84b48e55dcb0d054241424501017c05029ba1a55026d41e70b755c08b345417b6e10875193a7447a52fc7659b19d5fcb9d09fa0990d4d6e42f157eecc6219b63dd19bb28e1c90b9c7f67601158b")}))

Unit Tests

./src/archive/event.rs

Integration Tests

./src/archive/tests.rs

CC: @paritytech/tools-team.

[melekes]

👍 (code-wise; don't know enough to reason about business logic)

[melekes]

what's the point of returning finalized blocks here if that's not what the client has asked for? shouldn't we return an error instead saying that "the block with the given height has not been finalized yet"?

[lexnv]

Thanks for having a look at this!
I seem to have lost this in notifications, the archive class is not really necessary for light-client integrations and there are a few things to decide before moving forward with this:
paritytech/json-rpc-interface-spec#26, paritytech/json-rpc-interface-spec#27, paritytech/json-rpc-interface-spec#30, paritytech/json-rpc-interface-spec#29

Regarding this, we are also exploring adding another method archive_finalizedBlock to make sure users are aware they can make queries to ancestor blocks of finalized. IIRC, I placed this to make sure they are not making a call to any children of the finalized.

[melekes]

so previously we're only accessing offchain storage and now we need full storage, right?

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.