Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

TryDecodeEntireState check for storage types and pallets #13013

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

TryDecodeEntireState check for storage types and pallets #13013

wants to merge 15 commits into from

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Dec 23, 2022 •
edited
Loading

closes paritytech/polkadot-sdk#241

Add infrastructure needed to have a Pallet::decode_entire_state(), which makes sure all "typed" storage items defined in the pallet are decode-able.

This is not enforced in any way at the moment. Teams who wish to integrate/use this in the try-runtime feature flag should add frame_support::storage::migration::EnsureStateDecodes as the LAST ITEM of the runtime's custom migrations, and pass it to frame-executive. This will make it usable in try-runtime on-runtime-upgrade.

  • A follow-up issue should be made post-merge to integrate this into try-runtime-cli in a few places. Namely, we probably want this somehow integrated in follow-chain and fast-forward.
  • A follow-up issue should be made post-merge to integrate this into Polkadot runtimes, if CI finally allows.
  • Possibly a better way to handle feature gated storage items.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 23, 2022
@ggwpez
Copy link
Member

ggwpez commented Dec 23, 2022

I think 1. is a good start. It is opt-in and easy to use 👍

@ggwpez ggwpez mentioned this pull request Jan 2, 2023
Closed
@mustermeiszer mustermeiszer mentioned this pull request Jan 5, 2023
Open
@stale
Copy link

stale bot commented Jan 25, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 25, 2023
@stale stale bot closed this Feb 9, 2023
@kianenigma
Copy link
Contributor Author

Don't you dare bot.

@kianenigma kianenigma reopened this Feb 9, 2023
@stale stale bot removed A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. labels Feb 9, 2023
@kianenigma
Copy link
Contributor Author

This PR is mostly done, as is up for grabs if anyone wants to push it to completion.

@kianenigma kianenigma added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 17, 2023
@kianenigma kianenigma marked this pull request as ready for review March 17, 2023 19:15
@ggwpez ggwpez mentioned this pull request Mar 27, 2023
Closed
liamaharon
liamaharon approved these changes Apr 14, 2023
View reviewed changes
frame/support/src/traits/try_runtime.rs Outdated Show resolved Hide resolved
@ggwpez ggwpez mentioned this pull request May 8, 2023
Merged
@stale
Copy link

stale bot commented May 15, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label May 15, 2023
@stale stale bot removed the A3-stale label May 22, 2023
@juangirini juangirini requested review from ggwpez and a team June 9, 2023 14:39
@stale
Copy link

stale bot commented Jul 12, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 12, 2023
@stale stale bot removed A3-stale labels Jul 14, 2023
@kianenigma kianenigma requested a review from a team August 13, 2023 19:20
@kianenigma
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3429208

@PieWol PieWol mentioned this pull request Sep 9, 2023
Closed
@PieWol PieWol mentioned this pull request Oct 6, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muharem muharem muharem left review comments

@sam0x17 sam0x17 sam0x17 approved these changes

@liamaharon liamaharon liamaharon approved these changes

@KiChjang KiChjang Awaiting requested review from KiChjang

@ggwpez ggwpez Awaiting requested review from ggwpez

At least 2 approving reviews are required to merge this pull request.

Assignees

@kianenigma kianenigma

Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DecodeAll check for post_migrate hook
6 participants
@kianenigma @ggwpez @paritytech-cicd-pr @sam0x17 @muharem @liamaharon