Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Deprecate V1 Weights #13699

Merged
merged 12 commits into from
Apr 4, 2023
Merged

Deprecate V1 Weights #13699

merged 12 commits into from
Apr 4, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 23, 2023 •
edited
Loading

First round of cleanups to get completely rid of 1D weights. The struct will be removed soon.

🚨 Changes:

  • Remove calls alliance::close_old_weight and collective::close_old_weight.
  • Deprecate the OldWeight struct. Only exception is the contracts pallet where a copy of it resides.
  • Remove legacy runtime API call query_info_before_version_2.

Polkadot companion: paritytech/polkadot#7003
Cumulus companion: paritytech/cumulus#2431

@ggwpez
Remove deprecated pallet calls
2942617 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Deprecate old weight
aaa4e29 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Runtime API
834d1cb 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix tests
0f1e6ab 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Delete shitty code
7364067 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix doctest
9c71d76 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 23, 2023
@ggwpez ggwpez requested a review from a team March 23, 2023 17:39
@ggwpez ggwpez requested a review from athei as a code owner March 23, 2023 17:39
koute
koute approved these changes Mar 24, 2023
View reviewed changes
frame/support/src/dispatch.rs Show resolved Hide resolved
frame/alliance/src/lib.rs Outdated Show resolved Hide resolved
@athei
Copy link
Member

athei commented Mar 24, 2023

  • Deprecate the OldWeight struct. Only exception is the contracts pallet (cc @athei).

We basically need to support the old weight forever. Since existing APIs can't be changed. But we could just use u64 so we don't need to import the deprecated type.

@ggwpez
Copy link
Member Author

ggwpez commented Mar 24, 2023 •
edited
Loading

We basically need to support the old weight forever. Since existing APIs can't be changed. But we could just use u64 so we don't need to import the deprecated type.

Okay, I will move the type to the contracts pallet.
Just dont want to have it in public sp-* anymore.

It is done @athei

ggwpez and others added 3 commits March 24, 2023 12:35
@ggwpez @koute
Update frame/alliance/src/lib.rs
51254b9 
Co-authored-by: Koute <koute@users.noreply.github.com>
@ggwpez
Add doc
3c2fa19 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
contracts: Use u64 as old weight type
81668bc 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
athei
athei reviewed Mar 27, 2023
View reviewed changes
frame/contracts/src/lib.rs Outdated Show resolved Hide resolved
@ggwpez @athei
Update frame/contracts/src/lib.rs
6fe1f4f 
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
@ggwpez ggwpez requested a review from yjhmelody March 31, 2023 13:05
ggwpez added a commit to paritytech/polkadot that referenced this pull request Apr 4, 2023
@ggwpez
Remove old calls
035c87f 
Companion for paritytech/substrate#13699

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Apr 4, 2023
Merged
ggwpez added a commit to paritytech/cumulus that referenced this pull request Apr 4, 2023
@ggwpez
Remove old calls
b054353 
Removes calls that rely on the old weight and get removed in Substrate upstream.

Companion for paritytech/substrate#13699 and paritytech/polkadot#7003

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Apr 4, 2023
Merged
@ggwpez
Copy link
Member Author

ggwpez commented Apr 4, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@ggwpez
Copy link
Member Author

ggwpez commented Apr 4, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 7bbfe73 into master Apr 4, 2023
@paritytech-processbot paritytech-processbot bot deleted the oty-old-weight-cleanup branch April 4, 2023 18:57
paritytech-processbot bot pushed a commit to paritytech/polkadot that referenced this pull request Apr 4, 2023
@ggwpez
Co #13699: Remove old calls (#7003)
dc230b3 
* Remove old calls

Companion for paritytech/substrate#13699

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* update lockfile for {"substrate"}

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@ggwpez @koute
@athei @gpestana
Deprecate V1 Weights (#13699)
6c45413 
* Remove deprecated pallet calls

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Deprecate old weight

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Runtime API

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Delete shitty code

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix doctest

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/alliance/src/lib.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

* Add doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* contracts: Use u64 as old weight type

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/contracts/src/lib.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Co-authored-by: parity-processbot <>
@ggwpez ggwpez mentioned this pull request Apr 27, 2023
Closed
2 tasks
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1

@jasl jasl mentioned this pull request May 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@nazar-pc nazar-pc mentioned this pull request Jun 16, 2023
Merged
1 task
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Jul 11, 2023
@AurevoirXavier
Companion of paritytech/substrate#13699
961b45d
ggwpez added a commit to ggwpez/runtimes that referenced this pull request Jul 13, 2023
@ggwpez
Co #13699: Remove old calls (#7003)
ab49643 
* Remove old calls

Companion for paritytech/substrate#13699

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* update lockfile for {"substrate"}

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@ggwpez @koute
@athei @nathanwhit
Deprecate V1 Weights (paritytech#13699)
9b07140 
* Remove deprecated pallet calls

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Deprecate old weight

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Runtime API

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Delete shitty code

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Fix doctest

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/alliance/src/lib.rs

Co-authored-by: Koute <koute@users.noreply.github.com>

* Add doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* contracts: Use u64 as old weight type

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/contracts/src/lib.rs

Co-authored-by: Alexander Theißen <alex.theissen@me.com>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Koute <koute@users.noreply.github.com>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@athei athei athei approved these changes

@muharem muharem muharem approved these changes

@yjhmelody yjhmelody yjhmelody approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ggwpez @athei @Polkadot-Forum @koute @muharem @yjhmelody