Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert "sc-cli: add no-beefy flag to cli config (#14754)" #14766

Merged

Conversation

acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Aug 14, 2023

This reverts commit 2060c36.

Based on #14754 (comment)

polkadot companion: paritytech/polkadot#7613
cumulus companion: paritytech/cumulus#3007

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 14, 2023
@acatangiu acatangiu self-assigned this Aug 14, 2023
@acatangiu
Copy link
Contributor Author

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

@bkchr
Copy link
Member

bkchr commented Aug 15, 2023

@bkchr

I know that we also have there disable_grandpa, that is just some old oversight and we should not replicate it.

shall I also remove disable_grandpa then (remove --no-grandpa from sc-cli)? If yes, will do it as separate PR so that this is clean revert and nothing else.

Sounds like a good idea! WDYT @andresilva?

@acatangiu
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Github API says paritytech/polkadot#7613 is not mergeable

@andresilva
Copy link
Contributor

andresilva commented Aug 15, 2023

The disable_grandpa flag is used in both the node and node-template services, those are just using directly the RunCmd from sc-cli and it's probably not worth it to create their own RunCmd structs just for this. I'm fine with removing it, but it should still be added to polkadot IMO.

@acatangiu
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8a2c265 into paritytech:master Aug 15, 2023
62 checks passed
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants