This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Improve event json metadata #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
reviewed
Sep 11, 2018
| pub struct Module<T: Trait> for enum Call where origin: T::Origin {} | ||
| } | ||
|
|
||
| impl_event!( |
There was a problem hiding this comment.
prefer to keep naming consistently decl_ for this stuff
gavofyork
reviewed
Sep 11, 2018
| } | ||
| impl_event!( | ||
| pub enum Event<T> with RawEvent<AccountId, AccountIndex, Balance> | ||
| where <T as system::Trait>::AccountId, <T as Trait>::AccountIndex, <T as Trait>::Balance { |
There was a problem hiding this comment.
to avoid the problem of the indentation change not reflecting the block start, we move the trailing curly to the previous indent level and give it its own line in these circumstances., so this would become:
pub enum Event<T> with RawEvent<AccountId, AccountIndex, Balance>
where <T as system::Trait>::AccountId, <T as Trait>::AccountIndex, <T as Trait>::Balance
{
/// A new account was created.if the where clause becomes too big then this works:
pub enum Event<T> with RawEvent<AccountId, AccountIndex, Balance> where
<T as system::Trait>::AccountId,
<T as Trait>::AccountIndex,
<T as Trait>::Balance
{
/// A new account was created.
gavofyork
approved these changes
Sep 11, 2018
4 tasks
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Add EvilValidatorsPerSession and fix other nits * Split out slash.rs in staking
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Bumps [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) from 2.0.1 to 2.2.0. - [Release notes](https://github.com/Swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@22c9328...359a70e) --- updated-dependencies: - dependency-name: Swatinem/rust-cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.