This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
bugfix: balances::transfer for new_account issue#722 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue:paritytech#722 would_create flag should depend on dest, not origin. change ```rust let would_create = from_balance.is_zero(); ``` to ```rust let to_balance = Self::free_balance(&dest); let would_create = to_balance.is_zero(); ``` in the other hand, provide `fn new_test_ext2()` and let `transfer_fee=10`, `creation_fee=50` for test case
gavofyork
approved these changes
Sep 13, 2018
* Make `impl_outer_origin!` support generic `Origin`s * Support empty outer origin
|
:) |
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Deposit Reward event earlier Close paritytech#730 * Nit * . * Build wasm
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Split out reward.rs * Deposit Reward event earlier (paritytech#731) * Deposit Reward event earlier Close paritytech#730 * Nit * . * Build wasm * Refactoring for new distribution model (paritytech#735) * Split out reward.rs * Move reward related to reward.rs * Extract try_funding_team * Build wasm * Fix/opreturn parse (paritytech#732) * fix bug for transition_trustee_session * provide test for opreturn * provide new opreturn parser and tests * Add is_xss_proof (paritytech#737) * Add is_xss_proof * Apply is_xss_proof on token name and desc * Fix accounts tests * Cursory impl for new distribution model * Add multiply_by_rational * Clean up * Pub multiply_by_rational() * Move VoteWeight definition to traits.rs * Fix rls warnings in staking/src/lib.rs * Refactor reward.rs a bit * Refactor slash a bit * Nit * Add event when cross-chain assets grows too fast * Nits * Nits * Add default value * Test multiple_by_rational won't panic * Unify Reward event by introducing SessionReward * Nit
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
Removed in Rust 1.66: ``` warning: lint `const_err` has been removed: converted into hard error, see issue #71800 <rust-lang/rust#71800> for more information --> subxt/src/lib.rs:114:5 | 114 | const_err, | ^^^^^^^^^ | = note: `#[warn(renamed_and_removed_lints)]` on by default ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:#722
would_create flag should depend on dest, not origin.
change
to
in the other hand, provide
fn new_test_ext2()and lettransfer_fee=10,creation_fee=50for test case