This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Add RPC that allows instantiating of a contract #8451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
ascjones
reviewed
Mar 25, 2021
gui1117
approved these changes
Apr 13, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
…h#8451) * contracts: Add RPC that allows instantiating of a contract * Encode `debug_message` as bytes because usage of `String` is forbidden * Remove erroneous derive attribute * Fix rpc tests for new `debug_message` encoding * Fix typo Co-authored-by: Andrew Jones <ascjones@gmail.com> Co-authored-by: Andrew Jones <ascjones@gmail.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7379
This PR adds a new RPC called
contracts_instantiatethat allows dry-running contract instantiation. This is mainly of interests for general purpose UIs that now can offer the user guidance in choosing theendowmentandgas_limitparameter. Just like the existingcontracts_callRPC this one also returns thegas_consumed. In addition to this aRentProjectionis also returned which is helpful to give users feedback on the chosenendowment.Additionally, this PR also gets away with most of the wrapper types defined in the RPC crate by unifying them with the ones in the primitives crates. The only change to existing RPCs is that the unused
debug_messagefield is now encoded asBytesand not asString. This added some mostly boring code churn to this PR because many tests needed some trivial fixing because of this.cc @jacogr