fix: unsigned transaction metadata

[TarikGul]

A bug was introduced in 1.3.0 where I changed the metadataRpc field in the constructed unsigned transactions to point to registry.metadata.toHex(). For further details see polkadot-js/api#4293.

This PR introduces a fix in defineMethod where I generate the metadata outside of registry.setMetadata() and save it to its own variable so that generated metadata can then be used to be assigned to metadataRpc. This is important because it allows for a minimized size in transaction when using asCallsOnlyArg without tampering with the integrity metadata itself.

I also added a test for getRegistryBase that ensures when using asCallsOnlyArg that it will also minimize the metadata within the registry.

[lcovar]

Can confirm that this change will fix the issue in polkadot-js/api#4293. Thanks.

How soon can we expect a release after this is merged?

[TarikGul]

@lcovar Nice! Thanks for checking it out. We will release a patch tomorrow with these fixes.

[doodles92]

Hi @TarikGul we're from the Bitgo team. Can we confirm that this will go out tomorrow as it's blocking our development to onboard DOT to our platform.
CC: @lcovar

[TarikGul]

@doodles92 Yes can confirm this will be patched immediately, can't say when tomorrow exactly, but the goal is tomorrow regardless.

[emostov]

Can we re-export this via txwrapper-registry so its not duplicated?

[TarikGul]

It complains about circular dependencies. Being that the registry uses core, if core uses registry it wont build correctly.

[TarikGul]

@lcovar , @doodles92 - v1.3.2 has been released, and reflects these changes.