Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete node endpoint #731

Merged

Conversation

Eshanatnight
Copy link
Contributor

Description

Fix delete node endpoint behaviour


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated the delete ingester functionality, looks good to merge

@nikhilsinhaparseable nikhilsinhaparseable merged commit 01eb76c into parseablehq:main Apr 2, 2024
6 checks passed
@Eshanatnight Eshanatnight deleted the fix-delete-node-ep branch April 2, 2024 08:01
@Eshanatnight Eshanatnight restored the fix-delete-node-ep branch April 2, 2024 08:01
@Eshanatnight Eshanatnight deleted the fix-delete-node-ep branch April 2, 2024 08:02
nikhilsinhaparseable pushed a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants