Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Users API for Dashboads, caching and filters #798

Merged
merged 24 commits into from
May 24, 2024
Merged

Add Users API for Dashboads, caching and filters #798

merged 24 commits into from
May 24, 2024

Conversation

Eshanatnight
Copy link
Contributor

Description

Implement Query Results Caching. Add option ENV VAR P_QUERY_CACHE_DIR and P_QUERY_CACHE_SIZE.
Implement /dashboards endpoint. Implement /filters endpoint. Clean up errors.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@Eshanatnight Eshanatnight force-pushed the dashboard-api-addition branch 6 times, most recently from d40125b to e168cdd Compare May 21, 2024 07:26
@Eshanatnight
add the dashboards api
afaf87f
@Eshanatnight
add: filters api
4b22348
@Eshanatnight
add cli args for query caching
f121f74
@Eshanatnight
misc changes
721abf5
@Eshanatnight
update errors
e654177
@Eshanatnight
refactor: improve time parsing logic in query handler
e081a1b
@Eshanatnight
impl query result caching
455dc81
@Eshanatnight
update querying with cache
35118c8
@Eshanatnight
chore: clean up
89428f1
@Eshanatnight
impl query caching
810ad54
@Eshanatnight
add ability to store filters and dashboards in memory
284882c
@Eshanatnight
fix: bug if user_id is not provided
16f5a39
@Eshanatnight
misc add license headings
6348896
@Eshanatnight
cleanup rough edges
9d35e81
@Eshanatnight
update arrow flight server to perform query cache
83a358c
@Eshanatnight
fix: users root dir excluded when listing streams
e11f1db
@Eshanatnight
change the key for cache
9e9b4c7
@Eshanatnight
add cache endpoints
2d59640
@Eshanatnight
update .gitignore to exclude directory called cache
fd6422d 
.gitignore was excluding anything that matched the pattern `cache*`
causing the cache module to not be included
@Eshanatnight
fix bug if user id is not provided and query caching is enabled
77a7241 
Request hung up if the user_id was not provided in the header, of the
query request and query caching was enabled.
@Eshanatnight
add value check for the show_cached and cache_results headers
341ee6e
nikhilsinhaparseable
nikhilsinhaparseable approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nikhilsinhaparseable nikhilsinhaparseable merged commit 2b6739c into parseablehq:main May 24, 2024
7 checks passed
@Eshanatnight Eshanatnight deleted the dashboard-api-addition branch May 24, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eshanatnight @nikhilsinhaparseable