Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing the feature tour #703

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Implementing the feature tour #703

wants to merge 10 commits into from

Conversation

andreadelrio
Copy link
Contributor

Covers #624

Copy link
Contributor

@dethe dethe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, although there is a lot here. I've pushed to https://ppedia.surge.sh/ for wider testing.

@jesicarson
Copy link
Member

@dethe @andreadelrio Issues identified when reviewing on Surge:

  1. Didn't actually click the red marker, just brought my curser near it (maybe on it?) and it started the tour automatically. I expected to have to click it to activate. Thoughts?

  2. Search:
    The white highlight is hidden behind the top nav bar. Screenshot:
    screen shot 2018-01-08 at 5 37 17 pm

  3. Map copy edit (just updated the copy deck):
    Currently: The map shows cases and organizations around the world. Your search results are represented by red pins. Double click to zoom in. Select a red pin to find out more about.
    Should be: The map shows cases and organizations around the world. Your search results are represented by red pins. Double click to zoom in. Select any pin to find out more about a Case or Organization. Note, methods don’t appear on the map because they’re not location specific.

  4. Sort: jumped to highlight the all/cases/methods/orgs menu bar, but it was hidden behind the top nav bar. Also there's a strange opacity thing happening with the search bar with the white box behind it. screenshot:
    screen shot 2018-01-08 at 5 34 24 pm

  5. clicked "next" after sort (which showed 3/7) but the tour ended. No indication for users on how to start it up again (we should add something at the last tour item that says, go to help/contact to restart the tour). Anyway, when I restarted it, it ended after sort again.

@andreadelrio
Copy link
Contributor Author

@jesicarson thanks for reporting. I've made some changes. You can see them in staging now https://ppedia.surge.sh/

@jesicarson
Copy link
Member

@andreadelrio Thanks! Still seeing a few things:

  1. Same issue on Sort as number 4 above.

  2. Not sure if things are being highlighted in the top nav bar - are they? I see a very faint outline around the search bar and quick sub button. Maybe this isn't a big deal. It's pretty obvious what it's pointing to. Just seems like it could either be removed or exaggerated. But not priority.
    screen shot 2018-01-10 at 12 35 45 pm

  3. I went to Help & Contact and clicked "Show Tour" to start the tour, because it didn't start automatically (which is a good thing because it means it won't start automatcially if someone has been to the site before). It worked the first two times I ran through the tour, but on the third try, nothing happened. No red marker appeared. I tried again, nothing happened, the tour seems to be disabled.

  4. On the last tour item I think what you added about visiting Help & Contact to restart the tour is perfect. I would just recommend that the button should say "Finish" instead of "Last"

@dethe
Copy link
Contributor

dethe commented Mar 18, 2018

I was hoping we could merge and deploy this, but it isn't working smoothly on mobile (iPhone or iPad) according to testing by @plscully, so deferring for now while we get broken things fixed.

@LLPrin LLPrin self-assigned this May 5, 2018
@jesicarson
Copy link
Member

Is the feature tour live on xyz right now? I can't tell..

@dethe
Copy link
Contributor

dethe commented May 7, 2018

No, there was a problem with it on mobile. Lydia is going to look into it as one of her next tasks and then we can put it up.

@dethe
Copy link
Contributor

dethe commented May 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants