-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing the feature tour #703
base: master
Are you sure you want to change the base?
Conversation
two steps work for loginAvatar added more steps removed beacon from /case/id added tour to Case.js fixed editButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, although there is a lot here. I've pushed to https://ppedia.surge.sh/ for wider testing.
@dethe @andreadelrio Issues identified when reviewing on Surge:
|
@jesicarson thanks for reporting. I've made some changes. You can see them in staging now https://ppedia.surge.sh/ |
@andreadelrio Thanks! Still seeing a few things:
|
I was hoping we could merge and deploy this, but it isn't working smoothly on mobile (iPhone or iPad) according to testing by @plscully, so deferring for now while we get broken things fixed. |
Is the feature tour live on xyz right now? I can't tell.. |
No, there was a problem with it on mobile. Lydia is going to look into it as one of her next tasks and then we can put it up. |
No, there was a problem with it on mobile. Lydia is going to look into it
as one of her next tasks and then we can put it up.
…--Dethe
On Mon, May 7, 2018 at 11:23 AM, jesicarson ***@***.***> wrote:
Is the feature tour live on xyz right now? I can't tell..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#703 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABBuSdhU3QJXsJkgkUgt2UUnc1R5pT7ks5twJEUgaJpZM4RVlpb>
.
|
Covers #624