-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transcriptomic data integration #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Thanks @syamashiro28 !
I have several enhancement requests, please refer to the comments below.
code.R
:
- The file name is too abstract. Can you rename this, e.g.,
transcriptomic_data.R
? - Can you rename all function names to lowerCamelCase, e.g.,
mergeTCGAandCCLE
? - Currently, the name of final output file is "TPM_RLE_postComBat.csv". Is it possible to name this file depending on user-input like "TPM_RLE_postComBat_{TCGA-Abbreviation}_{CCLE-Abbreviation}.csv", e.g., "TPM_RLE_postComBat_BRCA_BREAST.csv"?
transcriptomic_data/requirements.txt
:
- We don't need this file. Can you remove this?
Thanks @syamashiro28 👏
Additional request:
|
No description provided.