Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transcriptomic data integration #14

Merged
merged 7 commits into from
Jul 16, 2021
Merged

Update transcriptomic data integration #14

merged 7 commits into from
Jul 16, 2021

Conversation

syamashiro28
Copy link
Collaborator

No description provided.

README.md Show resolved Hide resolved
Copy link
Contributor

@himoto himoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Thanks @syamashiro28 !
I have several enhancement requests, please refer to the comments below.
code.R:

  • The file name is too abstract. Can you rename this, e.g., transcriptomic_data.R?
  • Can you rename all function names to lowerCamelCase, e.g., mergeTCGAandCCLE?
  • Currently, the name of final output file is "TPM_RLE_postComBat.csv". Is it possible to name this file depending on user-input like "TPM_RLE_postComBat_{TCGA-Abbreviation}_{CCLE-Abbreviation}.csv", e.g., "TPM_RLE_postComBat_BRCA_BREAST.csv"?

transcriptomic_data/requirements.txt:

  • We don't need this file. Can you remove this?

@himoto himoto self-requested a review July 15, 2021 03:43
@himoto
Copy link
Contributor

himoto commented Jul 15, 2021

Thanks @syamashiro28 👏
Re-request:

  • Can you remove transcriptomic_data/requirements.txt?

Additional request:

  • Please fix biomass version to 0.5.0 to pass tests (will be updated soon).

    Edit requirements.txt as below.

    biomass==0.5.0
    matplotlib
    numpy
    pandas>=0.23
    seaborn>=0.11
    scipy>=1.2
    tqdm
    

@himoto himoto merged commit 1d06839 into master Jul 16, 2021
@himoto himoto deleted the update-r branch July 16, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants