Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arguments in value_transformation #24

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix arguments in value_transformation #24

merged 1 commit into from
Nov 25, 2021

Conversation

himoto
Copy link
Contributor

@himoto himoto commented Nov 18, 2021

Exchange origin and upstream arguments in value_transformation function

@himoto
Copy link
Contributor Author

himoto commented Nov 18, 2021 •
edited
Loading

@syamashiro28,
To my mind, it is more reasonable to call BRCA_TPM as 'origin' when transforming TPM values.
I fixed arguments of this function and description in README.
Please do let me know if this change can influence other files.

@himoto himoto merged commit 7500183 into master Nov 25, 2021
@himoto himoto deleted the value-transformation branch November 25, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syamashiro28 syamashiro28 syamashiro28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himoto @syamashiro28