refactor: make removing index.html from URL configurable #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranzke
changed the title
JosefBredereck
approved these changes
Sep 21, 2022
|
PR was released with v5.16.3 |
mfranzke
deleted the
refactor/make-removing-index.html-from-url-configurable
branch
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
…#1428) * refactor: providing the configurability for whether to remove index.html from the URL pattern-lab#1427 * docs(configuration): added entry for noIndexHtmlremoval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1427
Summary of changes:
I've decided to make this change configurable, especially for backwards "compatibility" (or in other words not changing the current behavior).
Providing the possibility to deactivate the initial redirect and changing of the history towards the removal of an included
index.htmlwithin the URL: from/index.html?p=WHATEVERto/?p=WHATEVER, as this might cause trouble on environments that don't acknowledge anindex.htmlfile if no file is provided in the URL.Even though that this is a suboptimal configuration, under some circumstances you're able to change it (like on a public static hosting provider).