Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Component pages Jumplinks responsive show/hide #4178

Closed
srambach opened this issue Aug 9, 2024 · 0 comments · Fixed by #4202
Closed

Bug - Component pages Jumplinks responsive show/hide #4178

srambach opened this issue Aug 9, 2024 · 0 comments · Fixed by #4202
Assignees
@rebeccaalpert
Labels
bug
Milestone
2024.Q3

Comments

@srambach
Copy link
Member

srambach commented Aug 9, 2024

Describe the problem
On the staging site (v6)
On component pages (maybe others) the jumplinks are

  • collapsed into a dropdown menu up to 1449px
  • at 1450px, the dropdown menu is suddenly expanded
  • at 1451px, the dropdown menu is removed but jumplinks at right side of page are not added
  • at 1466px, the jumplinks appear at the side of the page

Expected behavior
At all page widths, the jumplinks should be visible either in page or as a dropdown

Screenshots
I tried to get screenshots but Chrome devtools crashes each time as I expand the responsive view by single pixels 🤔
@srambach srambach added the bug label Aug 9, 2024
@dlabaj dlabaj added this to the 2024.Q3 milestone Aug 9, 2024
@rebeccaalpert rebeccaalpert self-assigned this Aug 16, 2024
rebeccaalpert added a commit to rebeccaalpert/patternfly-org that referenced this issue Aug 19, 2024
@rebeccaalpert
fix(docs): updated width on table of contents
5e257e4 
It looks like some of the widths changed since v5. This caused flex to stop wrapping the table of contents at the viewports mentioed in patternfly#4178. The table of contents was still present, but just at the bottom of the screen since the order was 1 (the main content is ordered at 0). Dropping down to this width seems to allow wrapping as expected again.

Should fix patternfly#4178
rebeccaalpert added a commit to rebeccaalpert/patternfly-org that referenced this issue Aug 19, 2024
@rebeccaalpert
fix(docs): updated width on table of contents
8ebd7e8 
It looks like some of the widths changed since v5. This caused flex to stop wrapping the table of contents at the viewports mentioned in patternfly#4178. The table of contents was still present, but just at the bottom of the screen since the order was 1 (the main content is ordered at 0). Dropping down to this width seems to allow wrapping as expected again.

Should fix patternfly#4178
@rebeccaalpert rebeccaalpert mentioned this issue Aug 19, 2024
Merged
rebeccaalpert added a commit to rebeccaalpert/patternfly-org that referenced this issue Aug 19, 2024
@rebeccaalpert
fix(docs): updated width on table of contents
bfe3ff8 
It looks like some of the widths changed since v5. This caused flex to stop wrapping the table of contents at the viewports mentioned in patternfly#4178. The table of contents was still present, but just at the bottom of the screen since the order was 1 (the main content is ordered at 0). Dropping down to this width seems to allow wrapping as expected again.

Should fix patternfly#4178
@rebeccaalpert rebeccaalpert linked a pull request Aug 19, 2024 that will close this issue
fix(docs): updated width on table of contents #4202
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebeccaalpert rebeccaalpert

Labels
bug
Projects
PatternFly Issues
Status: Done
Milestone
2024.Q3
Development

Successfully merging a pull request may close this issue.

fix(docs): updated width on table of contents rebeccaalpert/patternfly-org
3 participants
@dlabaj @rebeccaalpert @srambach