Skip to content

Commit

Permalink
address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@nicolethoen
nicolethoen committed Sep 1, 2023
1 parent 5f71787 commit 9354c52
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 29 deletions.
3 changes: 0 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,5 @@
"packages": [
"packages/**"
]
},
"dependencies": {
"@patternfly/react-icons": "5.0.0-alpha.15"
}
}
42 changes: 16 additions & 26 deletions packages/react-core/src/demos/DataListDemo.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -539,14 +539,14 @@ class DataListViewBasic extends React.Component {
<DataListCell isFilled={false} key="buttons1">
<Flex direction={{ default: 'column' }}>
<FlexItem>
<Text component={TextVariants.small}>patternfly</Text>
<Text component={TextVariants.p}>patternfly</Text>
</FlexItem>
<FlexItem>
<Text component={TextVariants.small}>
Working repo for PatternFly 4{' '}
<Button variant="link" isInline>
https://pf4.patternfly.org/
</Button>
Working repo for
<a href="http://www.patternfly.org/">
PatternFly
</a>
</Text>
</FlexItem>
<FlexItem>
Expand All @@ -571,9 +571,7 @@ class DataListViewBasic extends React.Component {
<Button variant="secondary">Action</Button>
</FlexItem>
<FlexItem>
<Button variant="link" isInline>
Link
</Button>
<a href="#">Link</a>
</FlexItem>
</Flex>
</DataListCell>
Expand Down Expand Up @@ -625,9 +623,7 @@ class DataListViewBasic extends React.Component {
<Button variant="secondary">Action</Button>
</FlexItem>
<FlexItem>
<Button variant="link" isInline>
Link
</Button>
<a href="#">Link</a>
</FlexItem>
</Flex>
</DataListCell>
Expand All @@ -652,9 +648,7 @@ class DataListViewBasic extends React.Component {
<Button variant="secondary">Action</Button>
</FlexItem>
<FlexItem>
<Button variant="link" isInline>
Link
</Button>
<a href="#">Link</a>
</FlexItem>
</Flex>
</DataListCell>
Expand All @@ -673,10 +667,10 @@ class DataListViewBasic extends React.Component {
</FlexItem>
<FlexItem>
<Text component={TextVariants.small}>
Working repo for PatternFly 4{' '}
<Button variant="link" isInline>
https://pf4.patternfly.org/
</Button>
Working repo for
<a href="http://www.patternfly.org/">
PatternFly
</a>
</Text>
</FlexItem>
<FlexItem>
Expand All @@ -702,9 +696,7 @@ class DataListViewBasic extends React.Component {
<Button variant="secondary">Action</Button>
</FlexItem>
<FlexItem>
<Button variant="link" isInline>
Link
</Button>
<a href="#">Link</a>
</FlexItem>
</Flex>
</DataListCell>
Expand All @@ -727,10 +719,10 @@ class DataListViewBasic extends React.Component {
<FlexItem>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>
<CodeBranchIcon />5
<CodeBranchIcon /> 5
</FlexItem>
<FlexItem>
<CodeIcon />9
<CodeIcon /> 9
</FlexItem>
<FlexItem>
<CubeIcon /> 2
Expand All @@ -755,9 +747,7 @@ class DataListViewBasic extends React.Component {
<Button variant="secondary">Action</Button>
</FlexItem>
<FlexItem>
<Button variant="link" isInline>
Link
</Button>
<a href="#">Link</a>
</FlexItem>
</Flex>
</DataListCell>
Expand Down

0 comments on commit 9354c52

Please sign in to comment.