Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Select): expose height and max height props for Menu content #10075

Merged
merged 3 commits into from
Feb 28, 2024
Merged

bug(Select): expose height and max height props for Menu content #10075

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dc2758
bug(Select): expose height and max height props for Menu contnet
tlabaj Feb 9, 2024
5a100dd
add isScrollable prop
tlabaj Feb 13, 2024
82855c7
Update packages/react-core/src/components/Select/Select.tsx
tlabaj Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/react-core/src/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ export interface SelectProps extends MenuProps, OUIAProps {
role?: string;
/** Additional properties to pass to the popper */
popperProps?: SelectPopperProps;
/** Height of the select menu */
menuHeight?: string;
/** Maximum height of select menu */
maxMenuHeight?: string;
/** Indicates if the select menu should be scrollable */
isScrollable?: boolean;
}

const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
Expand All @@ -87,6 +93,9 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
zIndex = 9999,
role = 'listbox',
popperProps,
menuHeight,
maxMenuHeight,
isScrollable,
...props
}: SelectProps & OUIAProps) => {
const localMenuRef = React.useRef<HTMLDivElement>();
Expand Down Expand Up @@ -151,14 +160,17 @@ const SelectBase: React.FunctionComponent<SelectProps & OUIAProps> = ({
}}
isPlain={isPlain}
selected={selected}
isScrollable={isScrollable}
{...getOUIAProps(
Select.displayName,
props.ouiaId !== undefined ? props.ouiaId : getDefaultOUIAId(Select.displayName),
props.ouiaSafe !== undefined ? props.ouiaSafe : true
)}
{...props}
>
<MenuContent>{children}</MenuContent>
<MenuContent menuHeight={menuHeight} maxMenuHeight={maxMenuHeight}>
{children}
</MenuContent>
</Menu>
);
return (
Expand Down
Loading