Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inklecate path configuration for multiple developers #35

Closed
BenjaminLawson opened this issue Apr 17, 2021 · 5 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@BenjaminLawson
Copy link

Currently, the inklecate settings path is shared by all developers for the same project. This is not viable because different developers have different paths to their inklecate binary.

Inkgd solves this by writing the binary paths to a config file that can be kept out of version control: https://github.com/ephread/inkgd#editor

@BenjaminLawson BenjaminLawson added the bug Something isn't working label Apr 17, 2021
@paulloz paulloz added enhancement New feature or request and removed bug Something isn't working labels Apr 17, 2021
@BenjaminLawson
Copy link
Author

BenjaminLawson commented Apr 17, 2021

If OS.execute supported relative or res:// paths this could also be solved by putting inklecate right in the project directory. Alas, it does not seem to.

Are there any viable workarounds?

paulloz added a commit that referenced this issue Jun 21, 2021
@paulloz
Copy link
Owner

paulloz commented Jun 21, 2021

Hey @BenjaminLawson, sorry I did not answer earlier.
I'm still thinking about what would be the best viable solution for this, this is a pretty big and important issue. I don't really like the idea of not using the proper Godot settings and making a separate configuration file though.
At the moment, I pushed a workaround in acea307. Like you suggested in your last comment, the setting is now relative to res:// so everything should at least be usable. I'm not a fan of not permitting to have inklecate outside the project's folder but it'll do for now. This change will be part of the next release.

@paulloz paulloz added the waiting for the next release This issue is resolved but waiting to be released label Jun 21, 2021
@francoisdlt
Copy link
Contributor

We have the same issue on our project, and since we have developers using Mac and Windows, this solution helps a little but does not solve all problems (since the inklecate binary is not the same for windows and mac)

I think i'll fork the plugin and have two distinct inklecate path properties : "inklecate-mac" and "inklecate-windows", both relative to res:// so we can version them and avoid conflicts.

@paulloz
Copy link
Owner

paulloz commented Jul 5, 2021 via email

@paulloz paulloz removed the waiting for the next release This issue is resolved but waiting to be released label Aug 8, 2021
@paulloz paulloz added the waiting for the next release This issue is resolved but waiting to be released label Jun 11, 2022
@paulloz paulloz reopened this Jun 11, 2022
@paulloz
Copy link
Owner

paulloz commented Jun 11, 2022

As of dde8c31, the setting can be overridden from a file that can be excluded from VCS. This will be available in 0.10.

@paulloz paulloz added this to the v0.10 milestone Jun 11, 2022
@paulloz paulloz closed this as completed Jun 11, 2022
@paulloz paulloz removed the waiting for the next release This issue is resolved but waiting to be released label Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants