Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mix formal parameters and arguments array #462

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milk-z
Copy link

@milk-z milk-z commented Feb 28, 2020

IE11 perf is significantly degraded when mixing formal parameters and the arguments array

Perf comparisons of mixing formal parameters and arguments vs not shows not mixing is much faster. And using only formal parameters vs using only arguments array shows similar perf.
mixed-perf
unmixed-perf

IE11 perf is significantly degraded when mixing formal parameters and the arguments array
@@ -1387,7 +1387,8 @@
var isBadHex = isBadHexRegex.test.bind(isBadHexRegex);
var NumberShim = (function () {
// this is wrapped in an IIFE because of IE 6-8's wacky scoping issues with named function expressions.
var NumberShim = function Number(value) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a breaking change; Number.length must be 1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that requirement! Thanks.
I will need to think about this some more then, just by having the formal parameter, even if only arguments is used, IE11 is much slower than only having formal parameters or only having arguments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately function lengths are not configurable in IE 11, so the only way to get a length of 1 is to have a formal parameter.

@@ -1387,7 +1387,8 @@
var isBadHex = isBadHexRegex.test.bind(isBadHexRegex);
var NumberShim = (function () {
// this is wrapped in an IIFE because of IE 6-8's wacky scoping issues with named function expressions.
var NumberShim = function Number(value) {
var NumberShim = function Number() {
var value = arguments[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i'm fine using the value out of the arguments object - however, if arguments.length < 1, arguments[0] deoptimizes in many engines, including older v8.

@ljharb ljharb marked this pull request as draft April 29, 2021 23:41
@ljharb ljharb force-pushed the master branch 3 times, most recently from 9647bf8 to 49a96e8 Compare October 24, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants