-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for adding properties to callog to track rac timestamp value #391
base: main
Are you sure you want to change the base?
Conversation
This change adds an extra 80 to 95 bytes for every RAC_ID cal event. This event triggers only in case of any RAC maintenance. Sample: |
lib/workerpool.go
Outdated
@@ -718,7 +718,7 @@ func (pool *WorkerPool) RacMaint(racReq racAct) { | |||
if logger.GetLogger().V(logger.Verbose) { | |||
logger.GetLogger().Log(logger.Verbose, "Rac maint activating, worker", i, pool.workers[i].pid, "exittime=", pool.workers[i].exitTime, now, window, pool.currentSize) | |||
} | |||
cnt++ | |||
racMaintWorkers = append(racMaintWorkers, []interface{}{pool.moduleName, pool.ShardID, i, pool.workers[i].exitTime, pool.workers[i].exitTime - now}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Instead of this, can we have an event inside this loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporated this review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not possible to add automated tests since RAC isn't in the express edition that github actions workflows tests on. Approving on my end to avoid blocking your internal steps.
No description provided.