Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#937 - Solution proposal #1072

Merged
merged 2 commits into from
May 5, 2023
Merged

#937 - Solution proposal #1072

merged 2 commits into from
May 5, 2023

Conversation

Netz00
Copy link
Contributor

@Netz00 Netz00 commented May 4, 2023

Waiting for comment, all tests passed.
I will add tests for this feature after it's approval.

Before

After:

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for xenodochial-hugle-b9ec84 ready!

Name Link
🔨 Latest commit 7a55e66
🔍 Latest deploy log https://app.netlify.com/sites/xenodochial-hugle-b9ec84/deploys/645535c483f61b00082ba07f
😎 Deploy Preview https://deploy-preview-1072--xenodochial-hugle-b9ec84.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pcottle
Copy link
Owner

pcottle commented May 4, 2023

Alright super close! This definitely resets the animation but I think it also prevents advancing to the next screen. When I tried it out using the green "right" arrow to advance through the lesson, I just got stuck in the loop of going to the reset button -> back to the original starting point, but I could never advance to the next part of the lesson.

I think this is because that positive method just puts us in a loop. I think we would need to do something like this:

onResetButtonClick: () => {
  this.demonstrated = false;
  this.takeControl();
}

and then just wire up the button click

Screenshot 2023-05-04 at 4 39 33 PM

Screenshot 2023-05-04 at 4 39 24 PM

@Netz00
Copy link
Contributor Author

Netz00 commented May 5, 2023

Yeah, sorry for that. I completely forgot to check it🤦🏻‍♂️. Should be fixed with the last commit.
I am glad the rest is okay, and I am not sure if I should add some tests.

@pcottle
Copy link
Owner

pcottle commented May 5, 2023

Looks great! Going to do two little polish things (change it to "Reset Animation" and maybe fade it out a bit) but thanks so much :D

@pcottle pcottle merged commit bdcb3e5 into pcottle:main May 5, 2023
@pcottle
Copy link
Owner

pcottle commented May 5, 2023

Screenshot 2023-05-05 at 4 06 03 PM

pcottle pushed a commit that referenced this pull request May 5, 2023
@Netz00 Netz00 deleted the feature-972-add-a-button-to-revert-the-animation branch May 6, 2023 09:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants