Fix issue on some devices drawer height was not 100% #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| const screenHeight = window.height | ||
| const screenWidth = window.width | ||
| const screenHeight = props.fullSize ? Dimensions.get('screen').height : window.height; | ||
| const screenWidth = props.fullSize? Dimensions.get('screen').width: window.width; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| } from "react-native" | ||
| import PropTypes from "prop-types" | ||
|
|
||
| const MenuDrawer = props => { | ||
| const fadeAnim = useRef(new Animated.Value(0)).current | ||
| const window = useWindowDimensions() | ||
| const screenHeight = window.height | ||
| const screenWidth = window.width | ||
| const screenHeight = props.fullSize ? Dimensions.get('screen').height : window.height; |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
|
After some more investigations, found out that this issue is related to andorid's three button navigation. Some android's have these buttons disabled hence the wrong value in |
|
@amn-max |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several devices that cause this issue. I have added in the fix as a optional propType
fullSize