Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally I intended to simply trigger a docker multiarch build, however it seems two changes were required to get the image to build:
npm
version 10+ are no longer compatible with the old version of nodejs we use, see https://stackoverflow.com/a/77024158/data
dir was not being created and resulted in an error when thechown
command was run, I'm not sure how this used to work, but amkdir
is now explicitly required.as an aside, this nodejs version is ancient, I'd like to upgrade that but I don't want to deal with that right now as there's enough going on with the multiarch changes.
for SEO, if the wrong baseimage is selected the errors manifest themselves as
Invalid ELF image for this architecture
or similar signs of architecture mismatch.