remove io/ioutil #910
Closed
remove io/ioutil #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ioutil has been deprecated, replace the calls to ioutil with the functions that are now called anyways.
|
Thank you for taking the time to make this change! I'm not keen on removing those deprecated imports yet, see #898 (comment). Essentially I think changing those imports will be worth it either in case of a new major version of go-toml, or when Go actually removes them, whichever comes first. |
|
Ironically, this is now done in #911 anyways :D |
|
I have no problem updating the imports in the program that generates tests :) |
|
I mean, only one of them was in an imported package anyways. The rest was in tests or main packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ioutil has been deprecated, replace the calls to ioutil with the functions that are now called anyways.