Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goreleaser action to v6 and set goreleaser binary to v2 #959

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

daniel-weisse
Copy link
Contributor

@daniel-weisse daniel-weisse commented Aug 7, 2024

goreleaser recently released version 2 of the tool.
This release deprecates the --rm-dist flag.
Since the version argument of the goreleaser/goreleaser-action of the release.yml workflow was set to latest, the action downloaded the newer version, breaking the workflow.

This PR updates the goreleaser action to v6 and pins the goreleaser binary version to any minor version of v2.
This should save the workflow from running into similar issues if gorelaser ever releases a v3 with other breaking changes.

b2e0fda updates the workflow.yml workflow to use the release.yml from the same commit the workflow was triggered on.
This is required for the checks to pass on this PR, as it updates that very same workflow.
Otherwise it takes the workflow from the last tag on v2.
If this is desired behavior, I can just drop the commit before merging.

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@pelletier
Copy link
Owner

Thank you for taking care of this! The change looks good to me, I will try to release a new version of go-toml sometime this coming week and we'll see how it goes!

@pelletier pelletier merged commit 0977c05 into pelletier:v2 Aug 17, 2024
11 checks passed
@pelletier pelletier added the build Issues regarding go-toml's CI system. label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues regarding go-toml's CI system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants