component: better test infrastructure #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
force-pushed
the
temp-storage
branch
from
8894677
to
490f325
Compare
|
@avahowell Could you look at the content of the IBC test and check that we didn't clobber anything? |
|
Merging optimistically to be able to do some changes to the |
|
the IBC test looks good to me, I like this test infrastructure approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1664
Closes #853
This commit cleans up the IBC client test as an example case of the new API.
Along the way, we also clean up some other ergonomic pain points, notably adding an
Arc<State>::try_begin_transaction()method.Co-Authored-By: Conor Schaefer conor@penumbra.zone