Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix argo diff in pvc template #373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KyriosGN0
Copy link
Contributor

@KyriosGN0 KyriosGN0 commented Sep 15, 2024

when deploying in argo the statefulset has a diff since we don't set the apiVersion and kind fields
fixes #358

Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0 KyriosGN0 requested review from spron-in and a team as code owners September 15, 2024 07:18
@KyriosGN0 KyriosGN0 requested review from BupycHuk and idoqo and removed request for a team September 15, 2024 07:18
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@spron-in
Copy link
Collaborator

@tplavcic could you please have a look?

@tplavcic
Copy link
Member

@spron-in LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Low] Deployment with ArgoCD generates warning in Persistent Storage once deployed...
3 participants