Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests - broadcaster disconnection & multiprocess #73

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

roekatz
Copy link
Contributor

@roekatz roekatz commented Apr 24, 2024

Fix race condition in broadcaster disconnection test by closing Websocket connection after disconnection.
Fix multiprocess test by switching from asyncio.get_event_loop().run_until_complete to asyncio.run (which is higher level, more stable and recommended to use)

@roekatz roekatz requested review from orweis and asafc April 24, 2024 09:38
@roekatz roekatz force-pushed the rk/fix-broadcaster-disconnection-test branch from efe3bb9 to 86c5ff2 Compare April 24, 2024 11:04
@roekatz roekatz force-pushed the rk/fix-broadcaster-disconnection-test branch from 8f203b9 to 00ebbb7 Compare April 24, 2024 11:25
@roekatz roekatz changed the title Tests: Fix broadcaster disconnection test race condition Fix failing tests - broadcaster disconnection & multiprocess Apr 24, 2024
@roekatz roekatz merged commit 70fdaae into master Apr 24, 2024
6 checks passed
@roekatz roekatz deleted the rk/fix-broadcaster-disconnection-test branch April 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants