Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add mypy stubs (Fixes #240) #283

Closed
wants to merge 1 commit into from

Conversation

JPTIZ
Copy link

@JPTIZ JPTIZ commented Jan 1, 2021

Thanks for taking the time to contibute to this project. You are a star!

Checks

Before you go any further, please make sure that you have read the contributing guidelines, run the test suite and that your clone of this repository was taken after 18 October 2018. (I had to fix up the git history and so clones before that date will have all sorts of merge issues).

Now please delete this pre-amble section and fill in the rest of the template...

Issues fixed by this PR

What does this implement/fix?

This PR:

  • Adds stubgen-generated stubs for the following libraries:
    • future
  • Adds missing typehints that mypy complains about

Any other comments?

This is a WIP

@JPTIZ JPTIZ changed the title Add mypy stubs [WIP] Add mypy stubs (Fixes #240) Jan 1, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.284% when pulling 68d9c16 on JPTIZ:typehints into 4ae88c6 on peterbrittain:master.

@peterbrittain
Copy link
Owner

I don't think we should be adding future stubs to asciimatics... Have you offered them to the future package maintainer instead?

@peterbrittain
Copy link
Owner

Looks like they might be amenable.... PythonCharmers/python-future#490

@JPTIZ
Copy link
Author

JPTIZ commented Jan 9, 2021

I don't think we should be adding future stubs to asciimatics... Have you offered them to the future package maintainer instead?

Hm, didn't think about that. That could be a solution, yes. I also agree that having the stubs in our repo wouldn't be very nice.

Looks like they might be amenable.... PythonCharmers/python-future#490

Indeed haha. Time to solve a 1 and a half year old issue. Ok, so I'll send them a PR and, in the meanwhile, solve other things with this one.

Would you recommend me to send PIL a similar PR? Since Mypy complained about stubs for it as well. They also have an open issue for that: python-pillow/Pillow#2625.

@peterbrittain
Copy link
Owner

Yeah - it looks like they also ground to a halt. Might be worth pointing out that type stubs can now be used in the package according to https://www.python.org/dev/peps/pep-0561/

@stale
Copy link

stale bot commented Mar 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 11, 2021
@stale stale bot closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants