Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add support for ClientAuthentication_hook #1785

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

draescherl
Copy link

@draescherl draescherl commented Jul 18, 2024

Hi, after #1738 a colleague and I tried our hands at implementing the ClientAuthentication_hook.

We took inspiration from 0703e63 but the tests don't pass and we can't figure out why. Do the tests not go through an auth phase? Any advice?

Thanks!

@eeeebbbbrrrr
Copy link
Contributor

Doesn't that hook require the extension be loaded by the postmaster, via shared_preload_libraries? Or maybe at least via session_preload_libraries?

That probably explains why the test framework isn't behaving the way you expect -- the test extension .so isn't actually loaded yet.

Not sure I have a suggestion yet, but that'd be my thought...

@workingjubilee
Copy link
Member

I think everything that requires shared_preload_libraries or session_preload_libraries should probably be behind a feature flag in pgrx itself, to make it obvious when people need to configure that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants