Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
bulid.rs
to simply write each schema file on a single line instead of building up a merge structure. This allows each schema to be fetched from the compiler, rather than justdistribution.schema.json
. It's simpler, too.Then update the
compiler
package to load each line into the compiler. This requires splitting the compiled-inschema_v1
andschema_v2
strings into lines, but it works just fine.Add a new method to the
valid
package,validate_release
, that validates aMETA.json
file that includes release metadata. Since the functionality is identical to the existingvalidate
method, aside from the schema name, refactor it into the newvalidate_schema
method, now simply dispatched by bothvalidate
andvalidate_release
.Expand the corpus test to test both
validate
andvalidate_release
by applying a patch containing valid release metadata. While there, add tests for the return values, to ensure that the correct verision is always returned from both methods.Finally, eliminate some redundant tests and test the string values of errors, then add tests for validation failures for both
validate
andvalidate_release
.