This repository has been archived by the owner on Oct 15, 2023. It is now read-only.
[roleutils] a simple cmd to change the role icon #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenom4n4n
suggested changes
Dec 7, 2022
| await role.edit(display_icon=await icon.read()) | ||
| elif isinstance(icon, discord.PartialEmoji) and icon.is_custom_emoji(): | ||
| await role.edit(display_icon=await icon.read()) | ||
| elif isinstance(icon, str) and icon.startswith("http"): |
There was a problem hiding this comment.
I don't want to be accepting any arbitrary URL to make a request to as this could lead to security issues. Rather than fetching content from the image itself, I'd do these two things:
- check
message.attachmentsand see if there's an image attachment that could be set as an icon - check
message.embedsand see if there's an embedded image that could be set as an icon
There was a problem hiding this comment.
Alright, understandable, I'm out for the week, will be done when i'm back home and have a stable internet.
|
Thanks for the PR. Please see the requested changes and implement them. |
Co-authored-by: PhenoM4n4n <61065078+phenom4n4n@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all, even tho I feel like it’s kinda unnecessary but can be useful at the same time, for instance it can be very useful for mobile users.