Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance release doesn't fully run on Windows #22

Closed
jbphet opened this issue Jun 10, 2016 · 2 comments
Closed

maintenance release doesn't fully run on Windows #22

jbphet opened this issue Jun 10, 2016 · 2 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Jun 10, 2016

There is an issue where npm install doesn't work on Windows due to some oddness about invoking it from scripts. As of this writing, the problematic code looks like this:

this.execute( 'npm', [ 'install' ], '../' + repo, function() {
        callback();
      } );

@jonathanolson put a workaround for a similar issue into test-server.js in chipper, and it looked like this:

  var npmInstall = spawn( 'node', [ 'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js', 'install' ], {
    cwd: rootDir + simName
  } );

This is, however, not a portable solution. We need to figure out something that will work on Windows as well as Unix-ish machines (i.e. OSX and Linux).

@jbphet
Copy link
Contributor Author

jbphet commented Jun 10, 2016

@jonathanolson found this and thinks it might be related: nodejs/node#3675.

@jonathanolson
Copy link
Contributor

I believe this is fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants