Skip to content

Commit

Permalink
[421] uplift to dotnet 7 (#423)
Browse files Browse the repository at this point in the history
* [421] uplift to dotnet 7

* update pr check
  • Loading branch information
philosowaffle committed Feb 17, 2023
1 parent d097b45 commit 71a01cb
Show file tree
Hide file tree
Showing 18 changed files with 23 additions and 35 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
dotnet: [ '6.0']
dotnet: [ '7.0']
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
dotnet: [ '6.0' ]
dotnet: [ '7.0' ]
os: [ 'win10-x64' ]
python-version: [ 3.9.6 ]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_distros_latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
dotnet: [ '6.0' ]
dotnet: [ '7.0' ]
#os: [ 'win10-x64', 'osx-x64' ] # osx signing issue, mac wont run the executable
os: [ 'win10-x64' ]
python-version: [ 3.9.6 ]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
dotnet: [ '6.0' ]
dotnet: [ '7.0' ]
#os: [ 'win10-x64', 'osx-x64' ] # osx signing issue, mac wont run the executable
os: [ 'win10-x64' ]
python-version: [ 3.9.6 ]
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile.api
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
###################
# CREATE FINAL LAYER
###################
FROM mcr.microsoft.com/dotnet/aspnet:6.0 as final
FROM mcr.microsoft.com/dotnet/aspnet:7.0 as final

ENV PYTHONUNBUFFERED=1
RUN apt-get update \
Expand All @@ -27,7 +27,7 @@ RUN mkdir -m770 {output,data,working}
###################
# BUILD LAYER
###################
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:6.0 AS build
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:7.0 AS build

COPY . /build
WORKDIR /build
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile.console
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
###################
# CREATE FINAL LAYER
###################
FROM mcr.microsoft.com/dotnet/aspnet:6.0 as final
FROM mcr.microsoft.com/dotnet/aspnet:7.0 as final

ENV PYTHONUNBUFFERED=1
RUN apt-get update \
Expand All @@ -27,7 +27,7 @@ RUN mkdir -m770 {output,data,working}
###################
# BUILD LAYER
###################
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:6.0 AS build
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:7.0 AS build

COPY . /build
WORKDIR /build
Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile.webui
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
###################
# CREATE FINAL LAYER
###################
FROM mcr.microsoft.com/dotnet/aspnet:6.0 as final
FROM mcr.microsoft.com/dotnet/aspnet:7.0 as final

RUN apt-get update \
&& apt-get -y install bash tzdata \
Expand All @@ -17,7 +17,7 @@ WORKDIR /app
###################
# BUILD LAYER
###################
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:6.0 AS build
FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:7.0 AS build

COPY . /build
WORKDIR /build
Expand Down
2 changes: 1 addition & 1 deletion docs/install/source.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ To compile and run P2G on your machine, follow the below steps.

## dotnet 6.0

1. Install the latest [dotnet 6.0 SDK](https://dotnet.microsoft.com/download/dotnet/6.0)
1. Install the latest [dotnet 7.0 SDK](https://dotnet.microsoft.com/download/dotnet/7.0)
1. Clone the GitHub repository locally
1. In the local repo, find the file named `configuration.example.json`. Make a copy of it and name it `configuration.local.json`.
1. Move `configuration.local.json` into the `src/PelotongToGarminConsole` directory
Expand Down
2 changes: 1 addition & 1 deletion src/Api/Api.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<PackageId>PelotonToGarmin.Api</PackageId>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
2 changes: 1 addition & 1 deletion src/Common/Common.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1591</NoWarn>
</PropertyGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Common/Constants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ public static class Constants
public const string ConsoleAppName = "p2g_console";
public const string ApiName = "p2g_api";
public const string WebUIName = "p2g_webui";
public const string AppVersion = "3.4.0-rc";

public const string AppVersion = "4.0.0-rc";
}
}
2 changes: 1 addition & 1 deletion src/Conversion/Conversion.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1591</NoWarn>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Garmin/Garmin.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1591</NoWarn>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Peloton/Peloton.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1591</NoWarn>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/PelotonToGarminConsole/PelotonToGarminConsole.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<AssemblyName>PelotonToGarminConsole</AssemblyName>
<RootNamespace>PelotonToGarminConsole</RootNamespace>
<RuntimeIdentifiers>win10-x64;osx-x64;linux-x64</RuntimeIdentifiers>
Expand Down
2 changes: 1 addition & 1 deletion src/Sync/Sync.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<Nullable>enable</Nullable>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>$(NoWarn);1591</NoWarn>
Expand Down
2 changes: 1 addition & 1 deletion src/UnitTests/UnitTests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>

<IsPackable>false</IsPackable>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/WebUI/WebUI.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win10-x64;osx-x64;linux-x64</RuntimeIdentifiers>
Expand Down
15 changes: 1 addition & 14 deletions vNextReleaseNotes.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,5 @@

## Features

- [#432] General Support for Garmin accounts protected by Two Step Verification
- WebUI - New setting added to enable 2FA
- Console (manual) - New setting added to enable 2FA
- Headless (automatic sync) - Does not support 2FA
- GitHub Action - Does not support 2FA
- [#438] On startup log path to config file being used
- [#421] Uplift to dotnet 7

## Fixes

- [#430] Fixed where error thrown for classes with `*` in the title

## Housekeeping

- [#434] Dependency Bumps
- [#435] More Dependency Bumps

0 comments on commit 71a01cb

Please sign in to comment.