Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditionally save fit files into GH action output #532

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

anlesk
Copy link
Contributor

@anlesk anlesk commented Sep 28, 2023

Prompted by: #526 (comment)

Saves the fit files as GH action artifacts

@philosowaffle philosowaffle merged commit a5d041d into philosowaffle:master Sep 28, 2023
@anlesk anlesk deleted the gh-action-save-output branch September 28, 2023 22:20
@adepue
Copy link

adepue commented Sep 30, 2023

This seems to cause an invalid config json file if you don't explicitly set save Local to true, as it omits the variable false. This error happened to me when running via GH Actions

 },
    "Format": {
      "Fit": true,
      "Json": false,
      "Tcx": false,
      "SaveLocalCopy": ,
      "IncludeTimeInHRZones": false,
      "IncludeTimeInPowerZones": false,
      "DeviceInfoPath": "./deviceInfo.xml"
    },
    "Peloton": {

Additionally, once setting to true, the output fails to save with a path character error:

Artifact path is not valid: /c46871a40e964879bf32d9c7055d7786_Extra_10:_Low_Impact_Ride_with_Matt_Wilpers.fit. Contains the following character: Colon : Invalid characters include: Double quote 

Haven't had a chance to look into it further yet, but noting here incase anyone happens to run into it or has immediate ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants