Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inconsistent schema usage in to_form example #2734

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

03juan
Copy link
Contributor

@03juan 03juan commented Jul 14, 2023

The example starts defining a user schema and then goes on to generate a blog post form and example parameters.

Updated example to be consistent with a post schema.

Also cleaned up the use of "which", which is generally seen as nonrestrictive (it could be left off without changing the meaning).

The example starts defining a user schema and then goes on to generate a blog post form and example parameters.

Updated example to be consistent with a post schema.

Also cleaned up the use of "which", which is generally seen as nonrestrictive (it could be left off without changing the meaning).
@03juan 03juan changed the title Updated inconsistent schema definition in to_form example Update inconsistent schema definition in to_form example Jul 14, 2023
@03juan
Copy link
Contributor Author

03juan commented Jul 14, 2023

Apologies, my decision to use a post schema was arbitrary. After reviewing the rest of the documentation for this module, it's better to stick to user.

@03juan 03juan changed the title Update inconsistent schema definition in to_form example Update inconsistent schema usage in to_form example Jul 14, 2023
@josevalim josevalim merged commit 1a79e78 into phoenixframework:main Aug 9, 2023
6 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants