Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 deprecations #768

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

ausi
Copy link
Contributor

@ausi ausi commented Jul 21, 2021

Fixes the PHP 8.1 deprecations of:

  1. https://wiki.php.net/rfc/internal_method_return_types
  2. https://wiki.php.net/rfc/deprecations_php_8_1#num_points_parameter_of_image_open_filled_polygon

We should probably wait with merging this until an RC version of PHP 8.1 was released.

@ausi
Copy link
Contributor Author

ausi commented Sep 27, 2021

PHP version 8.1.0-RC1 was released a month ago so I think this pull request is ready to merge.

@mlocati mlocati merged commit 60a78ce into php-imagine:develop Sep 30, 2021
@HVSoftware
Copy link

@ausi I see this fix is merged into the develop branch. Only this fix is not applies into the master branch. For this reason I cannot update to PHP 8.1 when using the master branch. Using the develop branch is not an option within my company. Can this fix also be applied to the master branch?

@ausi
Copy link
Contributor Author

ausi commented Jan 12, 2022

I think you have to wait until the next release. As far as I know the following issues have to be fixed before the version 1.3.0 can be released: https://github.com/php-imagine/Imagine/milestone/1

@mlocati
Copy link
Collaborator

mlocati commented Jan 12, 2022

Yep, we have a few issues that still need to be fixed. I've spent an insane amount of time trying to fix them, but no luck.

I'll try to find again some spare time to work on them (of course, any help is welcome)

@HVSoftware
Copy link

Clear. I will take a look at one of those issues. I'm not saying I can fix them. Only it would be nice if it can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants