Restore broken tests #820
Merged
Restore broken tests #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
force-pushed
the
restore-tests
branch
3 times, most recently
from
dba6b00
to
9e0ccc0
Compare
This restore broken tests by raising the minimum version to PHP 5.5, and testing on Windows with more recent PHP versions. Fixes php-imagine#780 Fixes php-imagine#781 Fixes php-imagine#783 Fixes php-imagine#784 Fixes php-imagine#785 Fixes php-imagine#786 Fixes php-imagine#788
PowerKiKi
force-pushed
the
restore-tests
branch
from
9e0ccc0
to
d6e52fe
Compare
Doubtful, #527 for context on why PHP 5.3 is still supported. |
The tests fail not because of old PHP versions, but because of old underlying ImageMagick versions (please remark: imagick is the PHP extension, ImageMagick is a system library). |
|
Thank you for merging this. Of course, the language itself is not the problem, but it's all related. Supporting decade old software require a significant amount of effort, and it will only get worse as time pass. I think you made the right choice by slightly reducing the maintenance scope for this project 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.5+ to restore broken tests
This restore broken tests by raising the minimum version to PHP 5.5,
and testing on Windows with more recent PHP versions.
Hopefully that is an acceptable compromise since PHP 5.3 and 5.4 are now over 10 years old.
Fixes #780
Fixes #781
Fixes #783
Fixes #784
Fixes #785
Fixes #786
Fixes #788