Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for segmentation fault on PHP 7.3 + opcache #828

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Workaround for segmentation fault on PHP 7.3 + opcache #828

merged 3 commits into from
Apr 1, 2022

Conversation

mlocati
Copy link
Collaborator

@mlocati mlocati commented Apr 1, 2022

Close #826

@mlocati mlocati mentioned this pull request Apr 1, 2022
Closed
ausi
ausi reviewed Apr 1, 2022
View reviewed changes
src/Gd/Image.php Outdated Show resolved Hide resolved
ausi
ausi approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the segmentation fault from #826

@mlocati
Copy link
Collaborator Author

mlocati commented Apr 1, 2022

Can confirm that this fixes the segmentation fault from #826

Thanks for checking.
I've also been able to replicate the issue inside the GitHub Actions (see #829).
So, I've rebased this PR: let's see if this #828 fixes the issue

@mlocati mlocati merged commit 4fa9471 into php-imagine:develop Apr 1, 2022
@mlocati mlocati deleted the segfault-workaround branch April 1, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault with GD on 1.3.1
2 participants
@mlocati @ausi