Ensure proper alignment of zend_accel_shared_globals.interned_strings #15359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Aug 12, 2024
Shouldn't be hard to set up; only a couple of lines for the push workflow would need to be adapted (PR #15361). On the other hand, this issue would probably not have been detected. Maybe we should set up a debug build; maybe ASan would have found it. Maybe more local x86 builds would help. Not sure; I'll try a bit. |
|
One possible option is to build with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15348
#13676 adds a assertion to check that
zend_accel_shared_globals.interned_strings.startis 8 bytes aligned, which in hindsight was not guaranteed. What is guaranteed is that the size of zend_strings in the buffer is a multiple of 8.Here I ensure that
zend_accel_shared_globals.interned_strings, and thuszend_accel_shared_globals.interned_strings.start, are 8-bytes aligned.