fix printf negative infinity #15965
Open
fix printf negative infinity #15965
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I was unaware. Close this PR then? this is a low-effort fix~ |
cmb69
reviewed
Sep 20, 2024
Comment on lines
+251
to
+253
| // ideally negative should have been handled inside php_sprintf_appendstring , | ||
| // but the code is difficult to debug, and it's easy to break stuff inside there (I tried, I broke stuff), | ||
| // handling it here is much easier.. |
| // ideally negative should have been handled inside php_sprintf_appendstring , | ||
| // but the code is difficult to debug, and it's easy to break stuff inside there (I tried, I broke stuff), | ||
| // handling it here is much easier.. | ||
| php_sprintf_appendstring(buffer, pos, "-INF", 4, 0, padding, |
There was a problem hiding this comment.
Hard-coding the min_width argument (4) here, looks wrong to me (I am aware that this already had been done this way before); see https://3v4l.org/WtHcq. Why not simply pass width instead? Same for the NaN and the -INF cases.
Comment on lines
+257
to
+258
| php_sprintf_appendstring(buffer, pos, "INF", 3, 0, padding, | ||
| alignment, 3, is_negative, 0, always_sign); |
There was a problem hiding this comment.
Instead of having an if-else, we could do:
Suggested change
| php_sprintf_appendstring(buffer, pos, "INF", 3, 0, padding, | |
| alignment, 3, is_negative, 0, always_sign); | |
| char *str = is_negative ? "-INF" : "INF"; | |
| php_sprintf_appendstring(buffer, pos, str, strlen(str), 0, padding, | |
| alignment, strlen(str), is_negative, 0, always_sign); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sprintf("%.17g", -INF);should return-INFnotINFresolves #15964
I tried fixing it inside php_sprintf_appendstring as it seems the original author intended, but.. that was difficult, and I broke other stuff.
(I think php_sprintf_appendstring would benefit from using smart_str https://www.phpinternalsbook.com/php7/internal_types/strings/smart_str.html , but idk how much effort that would be)