fixes per review

phpstan · Sep 8, 2022 · ec536c1 · ec536c1
1 parent ba9b91d
commit ec536c1
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/conf/bleedingEdge.neon b/conf/bleedingEdge.neon
@@ -18,3 +18,6 @@ parameters:
 		phpDocParserRequireWhitespaceBeforeDescription: true
 		runtimeReflectionRules: true
 		notAnalysedTrait: true
+
+rules:
+	- PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule
diff --git a/conf/config.level0.neon b/conf/config.level0.neon
@@ -72,7 +72,6 @@ rules:
 	- PHPStan\Rules\Methods\ExistingClassesInTypehintsRule
 	- PHPStan\Rules\Methods\FinalPrivateMethodRule
 	- PHPStan\Rules\Methods\MethodCallableRule
-	- PHPStan\Rules\Methods\MissingMagicSerializationMethodsRule
 	- PHPStan\Rules\Methods\MissingMethodImplementationRule
 	- PHPStan\Rules\Methods\MethodAttributesRule
 	- PHPStan\Rules\Methods\StaticMethodCallableRule

diff --git a/src/Rules/Methods/MissingMagicSerializationMethodsRule.php b/src/Rules/Methods/MissingMagicSerializationMethodsRule.php
@@ -11,6 +11,7 @@
 use PHPStan\Rules\RuleErrorBuilder;
 use Serializable;
 use function sprintf;
+use function strtolower;
 
 /**
  * @implements Rule<InClassNode>
@@ -51,10 +52,10 @@ public function processNode(Node $node, Scope $scope): array
 		$missingMagicSerialize = true;
 		$missingMagicUnserialize = true;
 		foreach ($nativeMethods as $method) {
-			if ($method->getName() === '__serialize') {
+			if (strtolower($method->getName()) === '__serialize') {
 				$missingMagicSerialize = false;
 			}
-			if ($method->getName() !== '__unserialize') {
+			if (strtolower($method->getName()) !== '__unserialize') {
 				continue;
 			}
 
@@ -65,13 +66,13 @@ public function processNode(Node $node, Scope $scope): array
 			$messages[] = RuleErrorBuilder::message(sprintf(
 				'Non-abstract class %s implements the Serializable interface, but does not implement __serialize().',
 				$classReflection->getDisplayName(),
-			))->build();
+			))->tip('See https://wiki.php.net/rfc/phase_out_serializable')->build();
 		}
 		if ($missingMagicUnserialize) {
 			$messages[] = RuleErrorBuilder::message(sprintf(
 				'Non-abstract class %s implements the Serializable interface, but does not implement __unserialize().',
 				$classReflection->getDisplayName(),
-			))->build();
+			))->tip('See https://wiki.php.net/rfc/phase_out_serializable')->build();
 		}
 
 		return $messages;

diff --git a/tests/PHPStan/Rules/Methods/data/missing-serialization.php b/tests/PHPStan/Rules/Methods/data/missing-serialization.php
@@ -27,3 +27,14 @@ public function serialize() {
 	public function unserialize($data) {
 	}
 }
+
+abstract class allGood implements Serializable {
+	public function serialize() {
+	}
+	public function unserialize($data) {
+	}
+	public function __serialize() {
+	}
+	public function __unserialize($data) {
+	}
+}